Skip to content
Snippets Groups Projects

Issue #3460610 by ammar_jeetawi: Add CKEditor Media Resize module and integrate it with Dynamic Responsive Image (Drimage) – Improved

Merged Issue #3460610 by ammar_jeetawi: Add CKEditor Media Resize module and integrate it with Dynamic Responsive Image (Drimage) – Improved

Remaining tasks

  • File an issue about this project
  • Addition/Change/Update/Fix to this project
  • Testing to ensure no regression
  • Automated unit/functional testing coverage
  • Developer Documentation support on feature change/addition
  • User Guide Documentation support on feature change/addition
  • UX/UI designer responsibilities
  • Accessibility and Readability
  • Code review from 1 Varbase core team member
  • Full testing and approval
  • Credit contributors
  • Review with the product owner
  • Update Release Notes and Update Helper on new feature change/addition
  • Release

Related to #3460610

Edited by Rajab Natshah

Merge request reports

Merged by Rajab NatshahRajab Natshah 5 months ago (Oct 9, 2024 7:09pm UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
1 ckeditor5:
1 ckeditor5:
2 2 css:
3 3 theme:
4 4 css/theme/varbase-editor.ckeditor5.admin.css: {}
5 media_resize_style:
  • 2 2 display: none !important;
    3 3 }
    4 4
    5 figure:has(.media--view-mode-original),figure:has(.media--view-mode-large) {
  • 277 if (!isset($full_html_editor_config_data['filters']['ckeditor_media_resize'])) {
    278 // Add ckeditor_media_resize as a dependency.
    279 $full_html_editor_config_data['dependencies']['module'][] = 'ckeditor_media_resize';
    280
    281 // Enable the Limit allowed HTML tags and correct faulty HTML filter.
    282 $full_html_editor_config_data['filters']['filter_html'] = [
    283 'id' => 'filter_html',
    284 'provider' => 'filter',
    285 'status' => TRUE,
    286 'weight' => -51,
    287 'settings' => [
    288 'allowed_html' => '<a id target rel class="ck-anchor" href title data-entity-type data-entity-uuid data-entity-substitution> <br> <p class="bs-callout alert alert-success bs-callout-info alert-info bs-callout-warning alert-warning bs-callout-danger alert-danger text-align-left text-align-center text-align-right text-align-justify"> <h2 class="display-1 display-2 display-3 display-4 display-5 display-6 text-align-left text-align-center text-align-right text-align-justify"> <h3 class="display-1 display-2 display-3 display-4 display-5 display-6 text-align-left text-align-center text-align-right text-align-justify"> <h4 class="display-1 display-2 display-3 display-4 display-5 display-6 text-align-left text-align-center text-align-right text-align-justify"> <h5 class="display-1 display-2 display-3 display-4 display-5 display-6 text-align-left text-align-center text-align-right text-align-justify"> <h6 class="display-1 display-2 display-3 display-4 display-5 display-6 text-align-left text-align-center text-align-right text-align-justify"> <div class="text-align-left text-align-center text-align-right text-align-justify"> <span> <strong> <em> <u> <code class="language-*"> <pre class="text-align-left text-align-center text-align-right text-align-justify"> <s> <sub> <sup> <blockquote> <ul> <ol reversed start> <li> <hr> <table> <tr> <td rowspan colspan> <th rowspan colspan> <thead> <tbody> <tfoot> <caption> <drupal-media data-entity-type data-entity-uuid alt data-view-mode data-caption data-align data-media-width> <figure class> <oembed url> <drupal-entity alt title data-align data-caption data-entity-embed-display data-entity-embed-display-settings data-view-mode data-entity-uuid data-langcode data-embed-button="gallery media node" data-entity-type="media node">',
    289 'filter_html_help' => TRUE,
    290 'filter_html_nofollow' => FALSE,
    291 ],
    292 ];
  • Rajab Natshah added 1 commit

    added 1 commit

    • 34a78425 - Issue #3460610: Optimize the integration for CKEditor Media Resize, Drimage –...

    Compare with previous version

  • Rajab Natshah added 1 commit

    added 1 commit

    • bcd3d4a3 - Issue #3460610: Optimize the integration for CKEditor Media Resize, Drimage –...

    Compare with previous version

  • Rajab Natshah added 1 commit

    added 1 commit

    • a51c4640 - Issue #3460610: Optimize the integration for CKEditor Media Resize, Drimage –...

    Compare with previous version

  • Rajab Natshah added 1 commit

    added 1 commit

    • 8b02e2e2 - Issue #3460610: Add a function to auto merge two allowed html string old and...

    Compare with previous version

  • Rajab Natshah added 1 commit

    added 1 commit

    • 712a2020 - Issue #3460610: Add add an extra trim and varbase_editor__ to the name of the...

    Compare with previous version

  • Rajab Natshah marked the checklist item Testing to ensure no regression as completed

    marked the checklist item Testing to ensure no regression as completed

  • Rajab Natshah marked the checklist item Code review from 1 Varbase core team member as completed

    marked the checklist item Code review from 1 Varbase core team member as completed

  • Rajab Natshah marked the checklist item Accessibility and Readability as completed

    marked the checklist item Accessibility and Readability as completed

  • Rajab Natshah marked the checklist item Full testing and approval as completed

    marked the checklist item Full testing and approval as completed

  • Rajab Natshah marked the checklist item Credit contributors as completed

    marked the checklist item Credit contributors as completed

  • Rajab Natshah approved this merge request

    approved this merge request

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading