Skip to content
Snippets Groups Projects

Issue #3451135: Switch from Drimage to Drimage Improved in Varbase Components

Merged Issue #3451135: Switch from Drimage to Drimage Improved in Varbase Components
issue/varbase_components-3451135:3451135-switch-from-driamge into 2.0.x
1 unresolved thread
Merged Rajab Natshah requested to merge issue/varbase_components-3451135:3451135-switch-from-driamge into 2.0.x
1 unresolved thread

Remaining tasks

  • File an issue about this project
  • Addition/Change/Update/Fix to this project
  • Testing to ensure no regression
  • Automated unit/functional testing coverage
  • Developer Documentation support on feature change/addition
  • User Guide Documentation support on feature change/addition
  • UX/UI designer responsibilities
  • Accessibility and Readability
  • Code review from 1 Varbase core team member
  • Full testing and approval
  • Credit contributors
  • Review with the product owner
  • Update Release Notes and Update Helper on new feature change/addition
  • Release

Related to #3451135

Edited by Rajab Natshah

Merge request reports

Approval is optional

Merged by Rajab NatshahRajab Natshah 11 months ago (Jun 4, 2024 3:28pm UTC)

Merge details

  • Changes merged into 2.0.x with 1c84d8a8 (commits were squashed).
  • Did not delete the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
components/molecules/dynamic-responsive-image/dynamic-responsive-image.twig
32 32 {% set item_attributes = create_attribute() %}
33 33 {% endif %}
34 34 {% set item_attributes = item_attributes.addClass(utility_classes) %}
35 {% set item_attributes = item_attributes.setAttribute('data-drimage', data|json_encode) %}
  • Rajab Natshah changed title from Issue #3451135: Switch from Driamge to Driamge Improved in Varbase Components to Issue #3451135: Switch from Drimage to Drimage Improved in Varbase Components

    changed title from Issue #3451135: Switch from Driamge to Driamge Improved in Varbase Components to Issue #3451135: Switch from Drimage to Drimage Improved in Varbase Components

  • Rajab Natshah added 1 commit

    added 1 commit

    • 51d95e5f - Change Drupal.drimage.init to Drupal.drimage_improved.init

    Compare with previous version

  • Rajab Natshah added 1 commit

    added 1 commit

    • 9a4cc325 - Change data-drimage_improved to data-drimage - after it was changed in drimage improved

    Compare with previous version

  • Rajab Natshah added 1 commit

    added 1 commit

    • 873a13ba - Change ata-drimage to data-drimage_improved as it was changed in Driamge Improved

    Compare with previous version

  • Rajab Natshah added 2 commits

    added 2 commits

    • a4e6b11e - 1 commit from branch project:2.0.x
    • aed5c7bb - Merge branch varbase_components:2.0.x into 3451135-switch-from-driamge

    Compare with previous version

  • Rajab Natshah marked the checklist item Testing to ensure no regression as completed

    marked the checklist item Testing to ensure no regression as completed

  • Rajab Natshah marked the checklist item Code review from 1 Varbase core team member as completed

    marked the checklist item Code review from 1 Varbase core team member as completed

  • Rajab Natshah marked the checklist item Full testing and approval as completed

    marked the checklist item Full testing and approval as completed

  • Rajab Natshah marked the checklist item Credit contributors as completed

    marked the checklist item Credit contributors as completed

  • Rajab Natshah marked the checklist item Review with the product owner as completed

    marked the checklist item Review with the product owner as completed

  • Rajab Natshah merged

    merged

    • Please register or sign in to reply