Skip to content

Issue #3457380: Add selection validation and retain css classes in editor

Chris Carlevato requested to merge issue/uswds_ckeditor_integration-3457380:3457380-uswds-grid-cannot into 3.0.x

Commit Summary

  • Add selection validation, fix console error and editor display
  • Replace static class with attribute in uswdsGrid downcast
  • Add class attribute to uswdsGridContainer downcast
  • Replace static class with attribute in uswdsGridRow downcast
  • Replace empty class in view with attribute in uswdsGridCol downcast
  • Replace "BS Grid" references with "USWDS Grid"
  • Run webpack build to incorporate changes into uswds_grid.js

Closes #3457380

Description

This merge request attempts to address the two items observed in issue #3457380.

  1. Validation of the selection (error caused editor to fail to display)
  2. Loss of necessary CSS classes within editor when editing existing grid content

Because CSS classes were included in the editor for columns their approach was adapted for grid/container/row. I'll add the caveat that this update was my introduction to CKEditor converters but it did net the behavior I think is intended so I'm sharing here as a starting point.

If there are any revisions or changes needed let me know and I'll be happy to take a stab at addressing them. Thanks!

Merge request reports