Issue #3225507 by Gábor Hojtsy, artatum, mglaman, AjitS: Upgrade_rector is not...

Issue #3225507 by Gábor Hojtsy, artatum, mglaman, AjitS: Upgrade_rector is not compatible with recent rector versions, should use the PHP configuration instead of YAML

composer.json

@@ -5,7 +5,7 @@
     "homepage": "http://drupal.org/project/upgrade_rector",
     "license": "GPL-2.0-or-later",
     "require": {
-        "palantirnet/drupal-rector": "~0.5"
+        "palantirnet/drupal-rector": "~0.11"
     },
     "minimum-stability": "dev"
 }

rector-config-template.php

+<?php
+
+use Rector\Core\Configuration\Option;
+use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;
+
+return static function (ContainerConfigurator $containerConfigurator): void {
+    $containerConfigurator->import($vendor_dir .  '/palantirnet/drupal-rector/config/drupal-8/drupal-8-all-deprecations.php');
+    $containerConfigurator->import($vendor_dir .  '/palantirnet/drupal-rector/config/drupal-9/drupal-9-all-deprecations.php');
+
+    $parameters = $containerConfigurator->parameters();
+    $parameters->set(Option::AUTOLOAD_PATHS, [
+        $drupal_root . '/core',
+        $drupal_root . '/modules',
+        $drupal_root . '/profiles',
+        $drupal_root . '/themes'
+    ]);
+    $parameters->set(Option::SKIP, ['*/upgrade_status/tests/modules/*']);
+    $parameters->set(Option::FILE_EXTENSIONS, ['php', 'module', 'theme', 'install', 'profile', 'inc', 'engine']);
+    $parameters->set(Option::AUTO_IMPORT_NAMES, true);
+    $parameters->set(Option::IMPORT_SHORT_CLASSES, false);
+    $parameters->set(Option::IMPORT_DOC_BLOCKS, false);
+
+    $parameters->set('drupal_rector_notices_as_comments', true);
+};

rector.yml

-imports:
-  - { resource: "%vendor_dir%/palantirnet/drupal-rector/config/drupal-8/drupal-8-all-deprecations.yml" }
-
-parameters:
-  autoload_paths:
-    - '%drupal_root%/core'
-    - '%drupal_root%/core/modules'
-    - '%drupal_root%/modules'
-    - '%drupal_root%/profiles'
-
-  file_extensions:
-    - module
-    - theme
-    - install
-    - profile
-    - inc
-    - engine
-
-  # If you would like Rector to include PHPUnit 8 upgrades, uncomment the following lines:
-  # sets:
-  #   - phpunit80
-  
-  exclude_paths:
-    - '*/upgrade_status/tests/modules/*'
-
-  # Create `use` statements.
-  auto_import_names: true
-  # Do not convert `\Drupal` to `Drupal`, etc.
-  import_short_classes: false
-  # This will not import classes used in PHP DocBlocks, like in /** @var \Some\Class */
-  import_doc_blocks: false
-
-  # This will add comments to call out edge cases in replacements.
-  drupal_rector_notices_as_comments: true
-
-services: ~

src/RectorProcessor.php

@@ -113,13 +113,11 @@ class RectorProcessor {
     }
 
     $module_path = DRUPAL_ROOT . '/' . drupal_get_path('module', 'upgrade_rector');
-    $config = file_get_contents($module_path . '/rector.yml');
-    // Even though Rector would resolve %vendor_dir% by itself, that would be
-    // relative to the rector-prefixed phar which is not what we need.
-    $config = str_replace('%vendor_dir%', $vendor_path, $config);
+    $config = file_get_contents($module_path . '/rector-config-template.php');
+    $config = str_replace('$vendor_dir', "'" . $vendor_path . "'", $config);
     // Replace backslash for Windows compatibility.
-    $config = str_replace('%drupal_root%', str_replace('\\', '/', DRUPAL_ROOT), $config);
-    $config_path = $temporary_directory . '/upgrade_rector.yml';
+    $config = str_replace('$drupal_root', "'" . str_replace('\\', '/', DRUPAL_ROOT) . "'", $config);
+    $config_path = $temporary_directory . '/rector-config.php';
     $success = file_put_contents($config_path, $config);
     if (!$success) {
       $this->rectorResults->set($extension->getName(), sprintf('Unable to write rector configuration to %s.', $config_path));

tests/src/Functional/UpgradeRectorUiTest.php

@@ -20,7 +20,7 @@ class UpgradeRectorUiTest extends BrowserTestBase {
   /**
    * {@inheritdoc}
    */
-  public static $modules = [
+  protected static $modules = [
     'upgrade_rector',
     'upgrade_rector_test_error',
   ];

upgrade_rector.module

@@ -18,7 +18,7 @@ function upgrade_rector_help($route_name, RouteMatchInterface $route_match) {
 /**
  * Implements hook_form_FORM_ID_alter().
  */
-function upgrade_rector_form_drupal_upgrade_status_form_alter(&$form, \Drupal\Core\Form\FormStateInterface $form_state, $form_id) {
+function upgrade_rector_form_drupal_upgrade_status_form_alter(&$form, FormStateInterface $form_state, $form_id) {
   // Weave in rector results with upgrade status results.
   $projects = \Drupal::service('upgrade_rector.project_collector')->collectProjects();
   $rector_results = \Drupal::service('keyvalue')->get('upgrade_status_rector_results');