Done.

Done, replaced with...

Completed, asset.query_string is now injected in the constructor.

Completed, file_url_generator is now injected in the constructor.

I believe the correct usage here is...

Done.

I had included it when I was testing out the 'advanced' section of the config form. Comment has been removed.

I think we should follow sorting here and move RoleInterface and Role use before Symfony line.

This should be converted to new call as before and use injected service asset.query_string reset() method.

We should inject asset.query_string service.

While doing all this refactoring, we should probably inject file_url_generator service and not use global one, detail explanation.

I think we should use injected logger here and not global logger call....