Skip to content
Snippets Groups Projects

Issue #3336970 by Grimreaper, pdureau: [2.0.0-alpha3] WIP: Fix config schema

Merged Issue #3336970 by Grimreaper, pdureau: [2.0.0-alpha3] WIP: Fix config schema
4 unresolved threads
4 unresolved threads

Closes #3336970

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
30 30 /**
31 31 * {@inheritdoc}
32 32 */
33 protected $strictConfigSchema = FALSE;
33 protected $strictConfigSchema = TRUE;
  • 1 views.style.ui_patterns:
    2 type: views_style
    3 label: 'Views style'
    4 mapping:
    5 ui_patterns:
    6 type: views.ui_patterns_configuration
    7 label: 'Views UI Patterns sub key'
    8
    9 views.ui_patterns_configuration:
    10 type: views_style
  • 1 ui_patterns_source.view_field:
    2 type: mapping
    3 label: 'Source: Token'
    4 mapping:
    5 ui_patterns_views_field:
    6 type: string
    7 label: 'Token value'
    8
    9 ui_patterns_source.view_rows:
    10 type: mapping
    11 label: 'Source: view_rows'
    12 mapping:
    13 ui_patterns_views_field:
  • added 1 commit

    Compare with previous version

  • 147 ui_patterns_source.field_property:*:*:*:
    148 type: mapping
    149 label: 'Source: Field Property'
    150 mapping:
    151 type:
    152 type: string
    153 label: 'Field Property type'
    154
    155 # block uses dynamic subkeys not under a specific key.
    156 # The configuration looks like:
    157 # plugin_id: block_id
    158 # block_id:
    159 # config_1: #
    160 # I cant find a solution to handle this correct. Sequences would work
    161 # if the the block_id key would be under an extra key. Something like config.block_id
    162 ui_patterns_source.block:
    • I need to check why ignore.

    • Ok, Got it.

      Then I think it may be a sign that current config structure is not good.

              sources:
                -
                  source_id: block
                  source:
                    plugin_id: system_branding_block
                    system_branding_block:
                      id: system_branding_block
                      label: 'Site branding'
                      ...
                  _weight: '0'

      Could it be converted into:

              sources:
                -
                  source_id: block
                  source:
                    plugin_id: system_branding_block
                    settings:
                      id: system_branding_block
                      label: 'Site branding'
                      ...
                  _weight: '0'

      ???

    • Please register or sign in to reply
  • added 1 commit

    Compare with previous version

  • Pierre Dureau added 13 commits

    added 13 commits

    Compare with previous version

  • Pierre Dureau enabled an automatic merge when all merge checks for ba08799d pass

    enabled an automatic merge when all merge checks for ba08799d pass

  • Pierre Dureau marked this merge request as ready

    marked this merge request as ready

  • Please register or sign in to reply
    Loading