Issue #3498456 by christian.wiedemann, grimreaper, pdureau: PHP warnings with computed fields

modules/ui_patterns_field_formatters/src/Plugin/UiPatterns/Source/FieldFormatterSource.php

@@ -444,10 +444,19 @@ class FieldFormatterSource extends FieldValueSourceBase implements TrustedCallba
   public function calculateDependencies() : array {
     $dependencies = parent::calculateDependencies();
     $configuration = $this->getConfiguration();
+    $fieldDefinition = $this->getFieldDefinition();
     if (empty($configuration['settings']['type'])) {
       return $dependencies;
     }
-    $formatter = $this->createInstanceFormatter($configuration['settings']['type'], $this->getFieldDefinition());
+    $formatter = NULL;
+    try {
+      $formatter = $this->createInstanceFormatter($configuration['settings']['type'], $fieldDefinition);
+    }
+    catch (\Throwable $exception) {
+      // During install computeDependencies instance this plugin.
+      // This can lead to unexpected configuration states. We can ignore it.
+    }
+
     if (!$formatter) {
       return $dependencies;
     }

src/Element/ComponentElementBuilder.php

@@ -215,13 +215,19 @@ class ComponentElementBuilder implements TrustedCallbackInterface {
    * @throws \Drupal\Core\Render\Component\Exception\ComponentNotFoundException
    */
   public function calculateComponentDependencies(?string $component_id = NULL, array $configuration = [], array $contexts = []) : array {
-    $component = $this->componentPluginManager->find($component_id ?? $configuration['component_id']);
     $dependencies = [];
-    if ($this->componentPluginManager instanceof UiPatternsComponentPluginManager) {
-      SourcePluginBase::mergeConfigDependencies($dependencies, $this->componentPluginManager->calculateDependencies($component));
+    try {
+      $component = $this->componentPluginManager->find($component_id ?? $configuration['component_id']);
+      if ($this->componentPluginManager instanceof UiPatternsComponentPluginManager) {
+        SourcePluginBase::mergeConfigDependencies($dependencies, $this->componentPluginManager->calculateDependencies($component));
+      }
+      SourcePluginBase::mergeConfigDependencies($dependencies, $this->calculateComponentDependenciesProps($component, $configuration, $contexts));
+      SourcePluginBase::mergeConfigDependencies($dependencies, $this->calculateComponentDependenciesSlots($component, $configuration, $contexts));
+    }
+    catch (\Throwable $exception) {
+      // During install mergeConfigDependencies can lead to
+      // unexpected configuration states. We can ignore it.
     }
-    SourcePluginBase::mergeConfigDependencies($dependencies, $this->calculateComponentDependenciesProps($component, $configuration, $contexts));
-    SourcePluginBase::mergeConfigDependencies($dependencies, $this->calculateComponentDependenciesSlots($component, $configuration, $contexts));
     return $dependencies;
   }
 

src/Plugin/Derivative/EntityFieldSourceDeriverBase.php

@@ -412,6 +412,11 @@ abstract class EntityFieldSourceDeriverBase extends DeriverBase implements Conta
       ->setLabel((string) ($entity_type_fields_data["label"] ?? ""));
     // Derive when bundle is unknown (in views for example)
     foreach ($entity_type_fields_data["field_storages"] as $field_name => $field_storage_data) {
+      if (!isset($field_storage_data["label"])) {
+        // During site install $field_storage_data is not setup completed.
+        // Skip for now.
+        continue;
+      }
       $field_name_context = (new ContextDefinition('string'))
         ->setRequired()
         ->setLabel("field_name")
@@ -443,6 +448,7 @@ abstract class EntityFieldSourceDeriverBase extends DeriverBase implements Conta
         ->setLabel("Bundle")
         ->addConstraint('AllowedValues', array_merge($field_storage_data["bundles"] ?? [], [""]));
       foreach ($field_storage_data["properties"] as $property_id => $property_data) {
+
         $base_plugin_derivative = array_merge($base_plugin_definition, [
           'label' => $property_data["label"],
           'context_definitions' => [