Issue #3475962 by pdureau: Cleaner meta:enum conversion

modules/ui_patterns_legacy/src/PropConverter.php

@@ -20,13 +20,7 @@ class PropConverter {
       'boolean' => [
         '$ref' => 'ui-patterns://boolean',
       ],
-      'checkboxes' => [
-        '$ref' => 'ui-patterns://enum_list',
-        'items' => [
-          'enum' => \array_keys($setting['options']),
-          'meta:enum' => $setting['options'],
-        ],
-      ],
+      'checkboxes' => $this->convertCheckboxes($setting),
       'links' => [
         '$ref' => 'ui-patterns://links',
       ],
@@ -34,16 +28,8 @@ class PropConverter {
         '$ref' => 'ui-patterns://machine_name',
       ],
       'number' => $this->convertNumber($setting),
-      'radios' => [
-        '$ref' => 'ui-patterns://enum',
-        'enum' => \array_keys($setting['options']),
-        'meta:enum' => $setting['options'],
-      ],
-      'select' => [
-        '$ref' => 'ui-patterns://enum',
-        'enum' => \array_keys($setting['options']),
-        'meta:enum' => $setting['options'],
-      ],
+      'radios' => $this->convertEnum($setting),
+      'select' => $this->convertEnum($setting),
       'textfield' => [
         '$ref' => 'ui-patterns://string',
       ],
@@ -57,6 +43,40 @@ class PropConverter {
     };
   }
 
+  /**
+   * Convert checkboxes.
+   */
+  private function convertCheckboxes(array $setting): array {
+    $values = \array_keys($setting['options']);
+    $labels = \array_values($setting['options']);
+    $prop = [
+      '$ref' => 'ui-patterns://enum_list',
+      'items' => [
+        'enum' => $values,
+      ],
+    ];
+    if (!empty(array_diff($values, $labels))) {
+      $prop['items']['meta:enum'] = $setting['options'];
+    }
+    return $prop;
+  }
+
+  /**
+   * Convert select and radios.
+   */
+  private function convertEnum(array $setting): array {
+    $values = \array_keys($setting['options']);
+    $labels = \array_values($setting['options']);
+    $prop = [
+      '$ref' => 'ui-patterns://enum',
+      'enum' => $values,
+    ];
+    if (!empty(array_diff($values, $labels))) {
+      $prop['meta:enum'] = $setting['options'];
+    }
+    return $prop;
+  }
+
   /**
    * Convert number.
    */