Add missing ui_patterns_source.icon config schema.
2 unresolved threads
2 unresolved threads
Compare changes
+ 17
− 0
- Comment on lines +10 to +17
Copy pasted from
field.value.ui_icon
.
Should we centralize this definition in ui_icons and use it for bothfield.value.ui_icon
andui_patterns_source.icon
to avoid duplication?Edited by Hervé Donner
Not 100% sure about this but the value can be NULL since
\Drupal\ui_icons_patterns\Plugin\UiPatterns\Source\IconSource::getPropValue
can return NULL. Maybe it should return an array instead?It's not clear for me on the UI patterns side, sources do as they want and
getPropValue()
is called only inDrupal\ui_patterns\SourcePluginBase::getValue()
which when NULL seems to be set as empty array when called elsewhere. SogetPropValue
can return array in all cases.