Skip to content
Snippets Groups Projects

Add missing ui_patterns_source.icon config schema.

Open Hervé Donner requested to merge issue/ui_icons-3493153:3493153-config-schema into 1.1.x
2 unresolved threads
1 file
+ 17
0
Compare changes
  • Side-by-side
  • Inline
ui_patterns_source.icon:
type: mapping
label: 'Source: Icon'
mapping:
value:
type: mapping
nullable: true
    • Not 100% sure about this but the value can be NULL since \Drupal\ui_icons_patterns\Plugin\UiPatterns\Source\IconSource::getPropValue can return NULL. Maybe it should return an array instead?

      • It's not clear for me on the UI patterns side, sources do as they want and getPropValue() is called only in Drupal\ui_patterns\SourcePluginBase::getValue() which when NULL seems to be set as empty array when called elsewhere. So getPropValue can return array in all cases.

      • Please register or sign in to reply
Please register or sign in to reply
label: 'Default icon value'
mapping:
target_id:
type: string
label: 'Default icon full ID'
settings:
type: sequence
label: 'Default icon settings'
sequence:
type: ui_icons.icon_pack_options.[%key]
    • Comment on lines +10 to +17

      Copy pasted from field.value.ui_icon.
      Should we centralize this definition in ui_icons and use it for both field.value.ui_icon and ui_patterns_source.icon to avoid duplication?

      Edited by Hervé Donner
Please register or sign in to reply
Loading