Resolve #3398815 "Php 8.2 support"
3 unresolved threads
Closes #3398815
Merge request reports
Activity
Filter activity
added 1 commit
- dc462926 - fix update syntax for partially supported callables
added 1 commit
- 9233e47b - fix: update syntax for partially supported callables
20 20 */ 21 21 public function getFilters() { 22 22 return [ 23 new TwigFilter('typogrify', [$this, 'filter'], ['is_safe' => ['html']]), 23 new TwigFilter('typogrify', $this->filter(...), ['is_safe' => ['html']]), changed this line in version 4 of the diff
24 24 /** 25 25 * Fri 9 Dec 2005. 26 26 */ 27 const SMARTYPANTS_PHP_VERSION = '1.5.1e'; 27 final public const SMARTYPANTS_PHP_VERSION = '1.5.1e'; 283 280 if ($cur_token[0] == 'tag') { 284 281 // Don't mess with quotes inside tags. 285 282 $result .= $cur_token[1]; 286 if (preg_match(self::SMARTYPANTS_TAGS_TO_SKIP, $cur_token[1], $matches)) { 283 if (preg_match(self::SMARTYPANTS_TAGS_TO_SKIP, (string) $cur_token[1], $matches)) { - Comment on lines -286 to +283
It looks to me as though
$cur_token[1]
is already a string. So I do not think that PHP will object here.PHPStan might object, but then I think a better fix is to add a
string[][]
declaration to Line 266 (where$tokens
is set) or astring[]
declaration to Line 279 (where$cur_token
is the loop variable).
added 4 commits
-
9233e47b...584ff271 - 3 commits from branch
project:8.x-1.x
- 99f2f060 - Merge branch '8.x-1.x' into '3398815-php-8.2-support'
-
9233e47b...584ff271 - 3 commits from branch
added 4 commits
-
99f2f060...89a3ab5e - 3 commits from branch
project:8.x-1.x
- e132c984 - Merge branch '8.x-1.x' into 3398815-php-8.2-support
-
99f2f060...89a3ab5e - 3 commits from branch
Please register or sign in to reply