Issue #3442636 Drupal 11 compatibility

Closes #3442636

added 1 commit

• 4e92a3bb - Fix PHPCS, mark parameters with null default value as nullable.

Compare with previous version

added 1 commit

• 898ae7d4 - Fix OR operator in core version requirement.

Compare with previous version

changed target branch from 2.1.x to 2.2.x

approved this merge request

After visiting /admin/structure/types/manage/article/fields/add-field page, I get Error 500:

TypeError: Cannot access offset of type Drupal\Core\StringTranslation\TranslatableMarkup in isset or empty in Drupal\Core\Plugin\DefaultPluginManager->doGetDefinition() (line 45 of core/lib/Drupal/Component/Plugin/Discovery/DiscoveryTrait.php).

It works fine in D10.

Hi @gpietrzak,

Thank you for noticing this, apparently the tests are not covering adding the field type in the UI. I just removed the 'category' property, as it can't be a translated string, but 'general' category is not in use anywhere in core (the Link field type doesn't define a category, and I think that's equivalent to saying it's general).

At the same time, I switched from annotations to using attributes for the plugins (as it's already used everywhere in core). This is done in: ea4cff74

I also bumped the minimum core 10 version to 10.2, because the plugin attributes were introduced in 10.2 4adbea9d (I discussed this change with @joevagyok)

Please have a look again.

added 1 commit

• ea4cff74 - Switch to attributes for field plugins.

Compare with previous version

reset approvals from @joevagyok by pushing to the branch

added 1 commit

• 4adbea9d - Increase core version requirement from 10 to 10.2.

Compare with previous version

Hi @keszthelyi, it looks good now, approved

merged