Skip to content
Snippets Groups Projects

#3371272 Fixing phpcs errors/warnings

Open #3371272 Fixing phpcs errors/warnings
issue/tmgmt_openai-3371272:1.0.x into 1.0.x
2 unresolved threads
Open Nitin Lama requested to merge issue/tmgmt_openai-3371272:1.0.x into 1.0.x
2 unresolved threads

#3371272 Fixing phpcs errors/warnings.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
src/OpenAiTranslatorUi.php
19 "GPT-3" => [
20 "text-davinci-003" => "text-davinci-003",
21 "text-davinci-002" => "text-davinci-002",
22 "text-davinci-001" => "text-davinci-001",
23 "text-curie-001" => "text-curie-001",
24 "text-ada-001" => "text-ada-001",
25 "text-babbage-001" => "text-babbage-001",
26 "davinci" => "davinci",
27 "davinci-instruct-beta" => "davinci-instruct-beta",
28 "curie" => "curie",
29 "curie-instruct-beta" => "curie-instruct-beta",
30 "babbage" => "babbage",
31 "ada" => "ada",
26 32 ],
27 33 ];
28 34
  • Comment on lines 13 to 28
    Chris Wu
    Chris Wu @amouro ·
    Contributor

    This part doesn't look correct, it has been reverted.

    It should use the new models

    Suggested change
    7 /**
    8 * OpenAI completion models.
    9 *
    10 * @var array
    11 */
    12 protected $models = [
    13 "GPT-3" => [
    14 "text-davinci-003" => "text-davinci-003",
    15 "text-davinci-002" => "text-davinci-002",
    16 "text-davinci-001" => "text-davinci-001",
    17 "text-curie-001" => "text-curie-001",
    18 "text-ada-001" => "text-ada-001",
    19 "text-babbage-001" => "text-babbage-001",
    20 "davinci" => "davinci",
    21 "davinci-instruct-beta" => "davinci-instruct-beta",
    22 "curie" => "curie",
    23 "curie-instruct-beta" => "curie-instruct-beta",
    24 "babbage" => "babbage",
    25 "ada" => "ada",
    26 ],
    27 ];
    28
    7 /**
    8 * OpenAI completion models.
    9 *
    10 * @var array $models
    11 */
    12 protected array $models = [
    13 "GPT-3.5" => [
    14 "gpt-3.5-turbo" => "gpt-3.5-turbo",
    15 "gpt-3.5-turbo-16k" => "gpt-3.5-turbo-16k",
    16 ],
    17 "GPT-4" => [
    18 "gpt-4" => "gpt-4",
    19 "gpt-4-32k" => "gpt-4-32k",
    20 ],
    21 ];
    22
  • Please register or sign in to reply
  • Chris Wu
    Chris Wu @amouro started a thread on an old version of the diff
    • src/Plugin/tmgmt/Translator/OpenAiTranslator.php
    17 17 use OpenAI\Responses\Chat\CreateResponse;
    18 18 use Rajentrivedi\TokenizerX\TokenizerX;
    19 19 use Symfony\Component\DependencyInjection\ContainerInterface;
    20 use Drupal\tmgmt\Translator\AvailableResult;
  • Chris Wu
    Chris Wu @amouro ·
    Contributor

    There are code reverted after the merge. It need some test and further review. I think this may need to run another phpcs against the new code.

  • Sakthi Shanmuga Sundaram M added 1 commit

    added 1 commit

    Compare with previous version

  • Nitin Lama added 1 commit

    added 1 commit

    Compare with previous version

  • Venkatraman G added 1 commit

    added 1 commit

    Compare with previous version

  • Anjali Mehta added 1 commit

    added 1 commit

    • 3d6bdee3 - fixed phpcs errors but remaining warnings

    Compare with previous version

  • Yashaswi Puthran added 1 commit

    added 1 commit

    Compare with previous version

  • Preethy Ray added 1 commit

    added 1 commit

    • 39f2be56 - Fixed phpcs errors and warnings

    Compare with previous version

  • shruu_rao added 3 commits

    added 3 commits

    Compare with previous version

    • Please register or sign in to reply