Skip to content
Snippets Groups Projects

Issue#3481622: Move declaration of $storage['plugin_label'] outside of if statement to fix...

Merged Issue#3481622: Move declaration of $storage['plugin_label'] outside of if statement to fix...
issue/tfa-3481622:3481622-pluginlabel-missing-in into 8.x-1.x
All threads resolved!
Merged lmoeni requested to merge issue/tfa-3481622:3481622-pluginlabel-missing-in into 8.x-1.x
All threads resolved!

Move declaration of $storage['plugin_label'] outside of if statement to fix missing plugin_label problem

Closes #3481622

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • C
    Conrad Lara @cmlara
    Developer

    Overall looks good, one suggestion about default text and a baseline removal. I can not see any reason this would not not work.

  • Conrad Lara requested changes

    requested changes

  • lmoeni added 1 commit

    added 1 commit

    • 23186e27 - Replace empty string with value and remove error from phpstan baseline

    Compare with previous version

  • lmoeni added 1 commit

    added 1 commit

    • fb0b9b9e - Replace empty string with value and remove error from phpstan baseline

    Compare with previous version

  • lmoeni resolved all threads

    resolved all threads

  • Conrad Lara approved this merge request

    approved this merge request

  • Conrad Lara bypassed reviews on this merge request

    bypassed reviews on this merge request

  • Conrad Lara merged

    merged

    • Please register or sign in to reply