Skip to content

Issue #3485349 Fix redirect to TFA when login destination modules are used

Closes #3485349

Problem/Motivation

When you have some modules like "Login And Logout Redirect Per Role", "Redirect After Login" etc, setting "Redirect users on login to TFA Setup Page" will not work. The reason is located at 105th line of TfaLoginForm.php

// Redirect user directly to the TFA account setup overview page.
            if ($this->getRequest()->request->has('destination')) {
              $this->getRequest()->query->remove('destination');
            }

It seems like a typo: value is checked in "request", but removed from "query"

Steps to reproduce

  1. Install and Enable module Login And Logout Redirect Per Role and configure some login destination for authenticated user.
  2. Set checkbox "Redirect users on login to TFA Setup Page" in TFA settings.
  3. Try to log in as user without TFA.

Merge request reports

Loading