Issue #3256740: Add an option to disable peer verification for SMTP
4 open threads
Merge request reports
Activity
added 1 commit
- a5b2fb94 - Switch up the logic to more logic ++ remove filte roption otherwise empty values are filtered out.
- Resolved by Adam Shepherd
16 16 */ 17 17 public function getDsn() { 18 18 $cfg = $this->configuration; 19 $query = !empty($cfg['query']) ? array_filter($cfg['query']) : []; 19 // Cannot do array_filter because this will filter out 0 params values. 20 // Which you want to disable verification for example. 21 $query = !empty($cfg['query']) ? $cfg['query'] : []; I can see why you changed this, however I think it breaks other code - currently SendmailTransport but there could be more. Instead I suggest we filter out values that are equal to the default defined in defaultConfiguration(). The default is often '' but it this case it is 1 or true or something similar.
changed this line in version 4 of the diff
- Resolved by Adam Shepherd
- Resolved by Adam Shepherd
added 1 commit
- ec4a1abe - Add smtp transport schema changes and other advanced smtp options to configuration form.
8 8 use Drupal\filter\Entity\FilterFormat; 9 9 use Drupal\symfony_mailer\Entity\MailerPolicy; 10 10 use Drupal\symfony_mailer\Entity\MailerTransport; 11 use Drupal\symfony_mailer\Plugin\MailerTransport\SmtpTransport; changed this line in version 4 of the diff
75 mapping: 76 local_domain: 77 type: string 78 label: 'HELO command domain name' 79 ping_threshold: 80 type: integer 81 label: 'Ping threshold' 82 restart_threshold: 83 type: integer 84 label: 'Restart threshold' 85 restart_threshold_sleep: 86 type: integer 87 label: 'Restart threshold sleep' 88 verify_peer: 89 type: boolean 90 label: 'Verify peer' changed this line in version 4 of the diff
72 69 '#max' => 65535, 73 70 ]; 74 71 72 $form['query']['verify_peer'] = [ 73 '#type' => 'checkbox', 74 '#title' => $this->t('TLS Peer Verification'), 75 '#description' => $this->t('It is not recommended to disable peer verification for security reasons, it can be useful while developing or when using a self-signed certificate.'), changed this line in version 4 of the diff
added 1 commit
- b020c5a3 - Add requested changes and other consistency/coding standards changes
added 25 commits
-
b020c5a3...042f1571 - 21 commits from branch
project:1.x
- cccbe6a7 - Add verify_peer option.
- 75202ec6 - Switch up the logic to more logic ++ remove filte roption otherwise empty values are filtered out.
- b46a4641 - Add smtp transport schema changes and other advanced smtp options to configuration form.
- 5eccb2d8 - Add requested changes and other consistency/coding standards changes
Toggle commit list-
b020c5a3...042f1571 - 21 commits from branch
Please register or sign in to reply