Issue #3257729: Formatters shouldn't repeat core code (!18) · Merge requests · project / svg_image · GitLab

Snippets Groups Projects

Merged Andrea Nironi requested to merge issue/svg_image-3257729:3257729-formatters-shouldnt-repeat into 3.x 2 years ago

Status	Pipeline	Created by	Stages
Passed 00:05:02 6 months ago	Issue #3257729: Formatters shouldn't repeat core code #334657 18 f6704dfb		Stage: build Stage: validate	Download artifacts No artifacts found
Passed 00:02:13 6 months ago	Remove unused use statement #331266 18 ab67d337		Stage: build Stage: validate	Download artifacts No artifacts found
Warning 00:03:26 6 months ago	Remove additional cache tags; unify code in both formatters in preparation for #3477774 #331262 18 e796bf51		Stage: build Stage: validate	Download artifacts No artifacts found
0
Passed 00:04:49 6 months ago	Simplify code further, bring back early opt-out #328223 18 bc330b82		Stage: build Stage: validate	Download artifacts No artifacts found
Passed 00:02:14 6 months ago	Simplify code further, bring back early opt-out #327497 18 a8a6f062		Stage: build Stage: validate	Download artifacts No artifacts found
Passed 00:02:16 7 months ago	Bring back the $imageStyle variable that is now used for dimension transformation. Fix phpcs. #324837 18 7d9db7d3		Stage: build Stage: validate	Download artifacts No artifacts found
Passed 00:03:34 7 months ago	Bring back the $imageStyle variable that is now used for dimension transformation. Fix phpcs. #313594 18 e9278f85		Stage: build Stage: validate	Download artifacts No artifacts found
Warning 00:02:39 7 months ago	Fix another phpcs issue #313573 18 eb8f0cd3		Stage: build Stage: validate	Download artifacts No artifacts found
0
Passed 00:02:15 8 months ago	Fix another phpcs issue #296981 18 72ad37c7		Stage: build Stage: validate	Download artifacts No artifacts found
Warning 00:02:18 8 months ago	Tidy up use statements #296952 18 16148871		Stage: build Stage: validate	Download artifacts No artifacts found
0
Warning 00:02:09 8 months ago	Use existing fileUrlGenerator variable #296941 18 81b9913c		Stage: build Stage: validate	Download artifacts No artifacts found
0
Warning 00:02:45 8 months ago	Use existing fileUrlGenerator variable #296871 18 de51c4b6		Stage: build Stage: validate	Download artifacts No artifacts found
0