Skip to content

Refactor inefficient code in settings form

Peter Epp requested to merge issue/spammaster-3451711:3451711-settings-form-code-improvements into 8.x-2.x

This is just one commit so far and there may yet be further improvements that can be done. I'm creating the merge request now so that the diff can be available to use as a patch for anyone who wants to use it. However, I may see additional improvements that can be made and if so I'll push some additional commits. Also it would be ideal for these changes to be reviewed before it's merged and included with a new release.

  • Break down code into separate methods for compiling the different pieces of information to display
  • DRY up code as much as possible (might still be further improvements that can be made)
  • Use simpler code where possible to compile lists of information to make that easier to read and maintain
  • Display the nice names of modules in the list of ones to disable
  • Make sure text is being correctly run through translation as much as possible
  • Minor coding standards updates

Closes #3451711

Merge request reports