Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • S soundcloudfield
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Custom issue tracker
    • Custom issue tracker
  • Merge requests 2
    • Merge requests 2
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Insights
    • Issue
    • Repository
  • Activity
  • Graph
  • Commits
Collapse sidebar
  • project
  • soundcloudfield
  • Merge requests
  • !5

Merged
Created Dec 08, 2021 by deckblad@deckblad

url parameter doesn't need to be encoded as Url::fromUri expects un-encoded query parameters

  • Overview 1
  • Commits 1
  • Changes 1

Closes #3253378

Pardon me, this is my first contrib on drupal git. Let me know if I'm messing up any expected standards.

I found, per the documentation, $url_params['url'] does not need to be urlencoded because line 284 Url::fromUri expects unencoded parameters per docs. https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Url.php/function/Url%3A%3AfromUri/9.0.x

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: 3253378-defaultphp-based-rendering-doesnt