Issue #3259613 by tim-diels: Permission "administer search api exclude entity" is confusing

search_api_exclude_entity.module

@@ -28,9 +28,9 @@ function search_api_exclude_entity_form_field_storage_config_edit_form_alter(&$f
  */
 function search_api_exclude_entity_entity_field_access($operation, FieldDefinitionInterface $field_definition, AccountInterface $account, FieldItemListInterface $items = NULL): AccessResultReasonInterface {
   if ($field_definition->getType() == 'search_api_exclude_entity' && $operation == 'edit') {
-    if (!$account->hasPermission('administer search api exclude entity')) {
-      return AccessResult::forbidden();
+    if ($account->hasPermission('edit search api exclude entity:')) {
+      return AccessResult::neutral();
     }
   }
-  return AccessResult::neutral();
+  return AccessResult::forbidden();
 }

search_api_exclude_entity.permissions.yml

-'administer search api exclude entity':
-  title: Administer search api exclude entity
-  description: Modify per-object exclude settings.
-  'restrict access': TRUE
+edit search api exclude entity:
+  title: 'Edit search api exclude entity'
+  description: 'Modify per-object exclude settings.'

search_api_exclude_entity.post_update.php

+<?php
+
+/**
+ * @file
+ * Post update functions for Search API Exclude Entity.
+ */
+
+/**
+ * Remove old Search API Entity Exclude permission with new permission.
+ */
+function search_api_exclude_entity_post_update_permission_update(): void {
+  $roles = \Drupal::entityTypeManager()->getStorage('user_role')->loadMultiple();
+  foreach ($roles as $role) {
+    if ($role->hasPermission('administer search api exclude entity')) {
+      $role->revokePermission('administer search api exclude entity');
+      $role->grantPermission('edit search api exclude entity');
+      $role->save();
+    }
+  }
+}