Skip to content
Snippets Groups Projects

Issue #3376141: Fix the issues reported by phpcs

3 unresolved threads
3 unresolved threads

Merge request reports

Members who can merge are allowed to add commits.
Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
21 22
22 23 use DependencySerializationTrait;
23 24
25 /**
26 * The current route match.
27 *
28 * @var \Drupal\Core\Routing\RouteMatchInterface
29 */
30 protected $routeMatch;
  • 214 227
    215 228 $vector_filter_ids = [];
    216 229
    217 // If entity types are configured, check if any of them are present in the route.
  • thanks, looks good, please check my comments.

  • Nitin Lama added 1 commit

    added 1 commit

    Compare with previous version

  • 28 36 * The OpenAI client.
    29 37 * @param \Drupal\Core\Entity\EntityTypeManagerInterface $entityTypeManager
    30 38 * The entity type manager.
    39 * @param \Drupal\Core\Routing\RouteMatchInterface $route_match
    40 * The route match.
    31 41 */
    32 public function __construct(
    33 private readonly Client $aiClient,
    34 private readonly EntityTypeManagerInterface $entityTypeManager,
    35 ) {}
    42 public function __construct(private readonly Client $aiClient, private readonly EntityTypeManagerInterface $entityTypeManager, RouteMatchInterface $route_match) {
    • Suggested change
      42 public function __construct(private readonly Client $aiClient, private readonly EntityTypeManagerInterface $entityTypeManager, RouteMatchInterface $route_match) {
      42 public function __construct(
      43 private readonly Client $aiClient,
      44 private readonly EntityTypeManagerInterface $entityTypeManager,
      45 protected RouteMatchInterface $routeMatch
      46 ) {}
    • Please register or sign in to reply
  • Thanks for update. Please check my comments.

  • Please register or sign in to reply
    Loading