Skip to content
Snippets Groups Projects

Update file explorer.css

Closed Update file explorer.css
issue/sdc_styleguide-3452566:3452566-iframe-conflicts-with into 1.0.x
1 unresolved thread
Closed IMMACULATE X requested to merge issue/sdc_styleguide-3452566:3452566-iframe-conflicts-with into 1.0.x
1 unresolved thread

Closes #3452566

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • IMMACULATE X
    IMMACULATE X @immaculate.x
    Author

    In this updated CSS:

    • .sdc-styleguide-page__viewer-wrapper now has position: relative to ensure its children, including the iframe, are positioned relative to it.
    • .sdc-styleguide-viewer__iframe is positioned absolutely within its container to prevent it from affecting the layout of other elements.
    • The height of .sdc-styleguide-viewer is adjusted to accommodate the border and padding.
    • These changes should resolve the issue with the iframe conflicting with the layout.
    Edited by IMMACULATE X
  • Alejandro Madrigal
    Alejandro Madrigal @alemadlei started a thread on the diff
css/explorer.css
25 25
26 26 .sdc-styleguide-page__viewer-wrapper {
27 27 height: 100%;
28 position: relative; /* Ensure the viewer wrapper handles positioning */
29 overflow: hidden; /* Prevent overflow issues */
28 30 }
29 31
30 32 .sdc-styleguide-viewer {
31 33 border: 2px dashed #161f50;
32 height: max(250px, 95%);
34 height: calc(100% - 2rem); /* Adjusting the height to accommodate border and padding */
  • Alejandro Madrigal
    Alejandro Madrigal @alemadlei
    Maintainer

    Hello!

    1. Could you remove the comments? They are not needed.
    2. The wraper should allow for scrolling when testing components.
    3. The iframe should not be absolute positioned. It just needs to fit the current contents.
    4. If adding style rules, please sort them alphabetically.
  • Please register or sign in to reply
  • Alejandro Madrigal closed

    closed

    • Please register or sign in to reply