Issue #3494839: AutowireTrait allows ContainerInjectionInterface classes to be autowired

Closes #3494839

modules/schemadotorg_diagram/src/Controller/SchemaDotOrgDiagramController.php

@@ -5,7 +5,6 @@ namespace Drupal\schemadotorg_diagram\Controller;
 use Drupal\Core\Controller\ControllerBase;
 use Drupal\node\NodeInterface;
 use Drupal\schemadotorg_diagram\SchemaDotOrgDiagramInterface;
-use Symfony\Component\DependencyInjection\ContainerInterface;
 
 /**
  * Returns responses for Schema.org Diagram.
@@ -13,18 +12,14 @@ use Symfony\Component\DependencyInjection\ContainerInterface;
 class SchemaDotOrgDiagramController extends ControllerBase {
 
   /**
-   * The Schema.org Diagram service.
-   */
-  protected SchemaDotOrgDiagramInterface $schemaDiagram;
-
-  /**
-   * {@inheritdoc}
+   * Constructs a SchemaDotOrgDiagramController objects.
+   *
+   * @param \Drupal\schemadotorg_diagram\SchemaDotOrgDiagramInterface $schemaDiagram
+   *   The Schema.org Diagram service.
    */
-  public static function create(ContainerInterface $container): static {
-    $instance = parent::create($container);
-    $instance->schemaDiagram = $container->get('schemadotorg_diagram');
-    return $instance;
-  }
+  public function __construct(
+    protected SchemaDotOrgDiagramInterface $schemaDiagram,
+  ) {}
 
   /**
    * Builds the response containing the Schema.org diagrams.