Aaron Bauman authored 7 years ago and Aaron Bauman committed 7 years ago

Issue #2896608 by aaronbauman: Last pull time tracked by SF object type but queries done per mapping

- update a few broken unit tests

Fixes QueueHandlerTest to works with changes to QueueHandler

Converting Queue and Delete Handlers into services, eliminating ::create methods, and updated tests.

PullBase’s logging not converted due to impending sweeping changes in
mads-30 branch to same file.

Adds DeleteHandlerTest (not quite working yet)
Removes injected Url object in RestClient. There is no @url service in core.services.yml and we’re
not supposed to use UrlGenerator. Since Url is only used once in RestClient::getAuthCallbackUrl(),
Url is used directly and that method can be easily mocked under test.
Cleans up salesforce_pull_cron()
Cleans up DeleteHandler’s use statements
Adds Request object to DeleteHandler’s constructor to handle REQUEST_TIME server global
Adds boolean returns to DeleteHandler methods for unit testing purposes
Fixes camel casing in MappedObjectStorage::loadBySfid() call in DeleteHandler
Converts try/catch pairs in DeleteHandler to non-exception based conditional logic to make logic
testable
Cleans up PullBase’s use statements
Adds event dispatcher service to PullBase’s constructor
Removes some property reference discrepancies in PullBase
Removes unnecessary code from PullBaseTest
Removes unnecessary code from QueueHandlerTest
Adds back in missing properties in a loadByProperties call in salesforce_push.module
Adds logger.factory service to PushQueue’s service definition in salesforce_push.services.yml
Changes logger service injection in PushQueue’s constructor to logger.factory service (there is
no logger service defined in core.services.yml)
Fixes all logger service references in PushQueue
Cleans up SalesforcePushQueueProcessor/Rest’s use statements
Removes EntityManager service injection in SalesforcePushQueueProcessor/Rest’s
constructor in favor of already existing EntityTypeManager service

Still to do:
DeletehandlerTest needs to pass - A deep property call is not working, causing the test to
error out.
Fix DeleteHandler’s call to property so it’s easier to mock under test
Address Warning: array_flip(): Can only flip STRING and INTEGER values! error in or around
SalesForcePullEvent
Fix PullBase’s multiple creation of same new Drupal entity (was fixed, now showing up again).

can find them

Removes needs for TestQueueHandler test class by
- adding state, request, and logger classes to QueueHandler constructor (injected)
- converting watchdog_exception calls to injected logger calls (also removes need to
  use LoggerTrait)
- stubs and overrides the parseUrl methods in a mock QueueHanlder class in the
  test code
Fixes a null object error with a trinary in PullBase
Does not fix all PullBase tests

to testable constructs.

Adds getter methods getDrupalEntityType and getDrupalBundle to
SalesforceMapping class to mirror getSalesforceObjectType
Fixes referencing errors in PullBase for testability
- Interfaces over classes
- Constant classes over global constable in *.module files
- Removal of t() use and using the implicit calls in the Drupal logger
- Protected methods over private methods
Adds PullBaseTest class (still needs work)
Fixes use list in QueueHandlerTest class
Add TestPullBase class to override necessary wrapper functions for PullBaseTest
Fixes use list in TestQueueHandler

Updates QuestHandler:
- moves several objects to decency injection
- adjusts constructor accordingly
- moves several Drupal::function calls and procedural functions to wrapper class
functions
- adds a true return to main methods for testability
Updates salesforce_pull_cron to call QueueHandler with new dependencies.
Adds TestQueueHandler test class to override problematic method/function
calls.

Moves functional calls to wrapper methods in QueueHandler for testability