Issue #3497252 by josue2591: Wrong default value on Settings Form and some...

Issue #3497252 by josue2591: Wrong default value on Settings Form and some fields not being save using the interface

src/Form/SettingsForm.php

@@ -127,7 +127,7 @@ class SettingsForm extends ConfigFormBase {
       '#title' => $this->t($definition['long_term_cache_lifetime']['label']),
       '#description' => $this->t($definition['long_term_cache_lifetime']['description']),
       '#type' => 'number',
-      '#default_value' => $config->get('short_term_cache_lifetime'),
+      '#default_value' => $config->get('long_term_cache_lifetime'),
     ];
 
     if ($this->moduleHandler->moduleExists('salesforce_push')) {
@@ -228,6 +228,8 @@ class SettingsForm extends ConfigFormBase {
     $config = $this->config('salesforce.settings');
     $config->set('show_all_objects', $form_state->getValue('show_all_objects'));
     $config->set('standalone', $form_state->getValue('standalone'));
+    $config->set('short_term_cache_lifetime', $form_state->getValue('short_term_cache_lifetime'));
+    $config->set('long_term_cache_lifetime', $form_state->getValue('long_term_cache_lifetime'));
     $config->set('global_push_limit', $form_state->getValue('global_push_limit'));
     $config->set('pull_max_queue_size', $form_state->getValue('pull_max_queue_size'));
     $config->set('limit_mapped_object_revisions', $form_state->getValue('limit_mapped_object_revisions'));