Resolve #3457486 "Mock for abstract class"

Closes #3457486

added 15 commits

• 4e37b643...133c7a13 - 5 earlier commits
• 4a200707 - Try removing strict_types
• 3798ce36 - Revert changes to RulesConditionContainerTest to get it to work again.
• 9786a5d1 - getMockConditionContainer() - One change at a time to see if it removes the...
• def0d946 - getMockConditionContainer() - Use test stub instead.
• 1a34099e - Revert "getMockConditionContainer() - Use test stub instead."
• 8cdb3425 - Revert "getMockConditionContainer() - One change at a time to see if it...
• c05f2426 - testNegate() - One change at a time to see if it removes the phpstan message and also still works.
• 2b96d10f - Remove possibly failing code?
• f7bc4615 - Is disableOriginalConstructor the problem?
• c7e97859 - Use concrete class?

Compare with previous version

marked this merge request as ready

added 2 commits

• 004ba287 - Make test stub non-abstract
• f41ec6a7 - Try to fix the mess that has become RulesConditionContainerTest

Compare with previous version

added 1 commit

• 1bad417c - Comment out some code to see where testbot is failing

Compare with previous version

added 1 commit

• d49451a0 - Instantiate stub instead of creating a mock for it.

Compare with previous version

added 1 commit

• b09e9de9 - Do the same for the two tests with disableOriginalConstructor()

Compare with previous version

added 1 commit

• 3c898c85 - Refactor to put common code into utility test method.

Compare with previous version

added 1 commit

• ed94ecd4 - Restore the last test case.

Compare with previous version

added 1 commit

• 57039b72 - Remove last of the commented out code.

Compare with previous version

merged