Loading
feat: #3616090 Repoint the blog view and its Canvas content templates to the site template theme
Issue: #3616090 Initialize the RightUp site template recipe and start the 1.0.x branch
The recipe carried no theme-repointing actions, so configuration that arrives from varbase_blog_base kept naming the base theme:
views.view.blogbound itsall,latestandrelateddisplays tovartheme_bs5:grid,vartheme_bs5:views-view-gridandvartheme_bs5:views-view-unformatted.- All 19
canvas.content_template.node.blog.*referenced 13 distinctvartheme_bs5:*components that do not exist on a RightUp site.
Blog article pages returned HTTP 500 with AssertionError: assert($component instanceof Component) from Drupal\canvas\Plugin\Field\FieldType\ComponentTreeItemList line 479, and the Home and Blog pages printed a Twig LoaderError where the article grid belongs.
What this adds
views.view.blog:setViewsComponentStyleThemewiththeme: default, plus the three per-displaycomponent_idvalues as dotted leaf paths, so the options the base recipe set are not replaced.repointComponentTreeToThemewiththeme: defaulton each of the 19 blog content templates.- An explicit
drupal/varbase_recipesrequirement. It provides both config action plugins and was reaching a site only through the base project's lock file, which is what makes a require onto another codebase abort withPluginNotFoundException.
Same shape the sibling site templates already use.
Verified
Re-installed on Varbase 11 from a dropped database, through drush site:install varbase installer_site_template_form.add_ons=rightup, exit 0:
- zero configuration objects still naming
vartheme_bs5: views.view.blogdisplays nowvartheme_bs5_rightup:grid,:views-view-grid,:views-view-unformatted- 12 of 12 blog article pages return 200, previously 0 of 12
- all 5 Canvas pages return 200, and the Twig
LoaderErroris gone from Home and Blog - zero error-severity watchdog rows
Notes on two things that are not settled
- The
drupal/varbase_recipes: 1.0.x-devconstraint is the maintainer's explicit choice. It is consistent with the other Varbase base recipes this file already pins, and worth reading together with #3620120: the existing dev pins are why a barecomposer require drupal/rightup:1.0.x-devfails against a codebase whose lock holds the released base recipes, and-Wis currently needed on that path. This change adds one more pin of the same kind. - A separate installer failure on a hand-built codebase is NOT root-caused. Requiring the recipe from a local vcs clone of a dev branch left
/core/install.phpas a bare "Error" page withTypeError: Drupal\RecipeKit\Installer\Hooks::getRecipePath(): Return value must be of type string, null returned, afterdrupal/core-recipe-unpackremoveddrupal/rightupfrom the rootcomposer.jsonand the lock while leaving it invendor/composer/installed.php. The verification above is on a project built by the workspace builder, requiringdrupal/rightup:1.0.x-devfrompackages.drupal.org. The hand-built path is not verified and is not claimed to be.
AI-Generated: Yes
Checkpoints:
- File an issue
- Addition/Change/Update/Fix
- Testing to ensure no regression
- Automated unit testing coverage
- Automated functional testing coverage
- UX/UI designer responsibilities
- Readability
- Accessibility
- Performance
- Security
- Developer Documentation
- User Guide Documentation
- Reviewed by human
- Code review by maintainers
- Full testing and approval
- Credit contributors
- Review with the product owner
- Release notes snippet
- Release
Edited by Rajab Natshah