fix: #3622619 Point the admin favicon and the Gin logos at the RightUp theme

Rajab Natshahrequested to merge
issue/rightup-3622619:3622619-gin-gin-login into 1.0.x

Fixes #3622619: Gin, Gin Login and Navigation point at Varbase profile images that 404 on Drupal CMS.

Problem / Motivation

On a fresh RightUp install (Drupal CMS 2.1.4, Drupal core 11.4.6), the Varbase admin base recipe leaves Gin, Gin Login and Navigation pointing at images inside the Varbase profile and the Varbase starter theme, neither of which exists on a Drupal CMS site:

  • gin.settings favicon.path = profiles/contrib/varbase/images/favicon.ico
  • gin.settings logo.path = profiles/contrib/varbase/images/varbase-medium-logo-emblem-color.png
  • /profiles/contrib/varbase/images/favicon.ico answers HTTP 404

So every admin page emits a failed request, and the functional suite fails with it: the ECA workflow modeler bucket's "no JavaScript errors" check trips on "Failed to load resource" for that favicon.

Proposed resolution

RightUp's own recipe config actions now point the admin branding at assets it actually ships, rather than patching the third-party Varbase admin recipe:

  • gin.settings: favicon.path and logo.path at themes/contrib/vartheme_bs5_rightup/favicon.ico and logo.svg, with favicon.mimetype set and use_default off for both.
  • gin_login.settings: logo.path at the theme's logo.svg, use_default off.
  • navigation.settings: logo.provider back to default, until the theme ships a square icon suited to the Navigation rail.

Plus a CHANGELOG entry under Unreleased / Fixed.

Verification

Check Before After
gin.settings favicon.path profiles/contrib/varbase/images/favicon.ico themes/contrib/vartheme_bs5_rightup/favicon.ico
that favicon over HTTP 404 200
the theme's logo.svg over HTTP - 200

Both theme assets exist in the shipped theme (favicon.ico, logo.svg).

Checkpoints

  • File an issue
  • Addition/Change/Update/Fix
  • Testing to ensure no regression
  • Automated unit testing coverage
  • Automated functional testing coverage
  • Developer Documentation support
  • User Guide Documentation support
  • UX/UI designer responsibilities
  • Accessibility and Readability
  • Reviewed by a human
  • Code review by maintainers
  • Full testing and approval
  • Credit contributors
  • Review with the product owner
  • Update Release Notes
  • Release

AI-Generated: Yes

Edited by Rajab Natshah

Merge request reports