fix: #3620714 Remove the dead Terms and Conditions link and the duplicate Privacy policy link

Rajab Natshahrequested to merge
issue/rightup-3620714:3620714-footer-menu-links into 1.0.x

Fixes the two footer menu defects in #3620714.

What changed

Two menu links are removed from the default content:

  • footer--04--terms-and-conditions.yml - points at /terms-and-conditions, for which the site template ships no page, no node and no alias. Nothing else in the template references the path.
  • footer--05--privacy-policy.yml - "Privacy Policy", duplicating the "Privacy policy" entry that drupal_cms_privacy_basic already supplies, so the same destination rendered twice under two capitalisations.

Evidence, from a fresh install

The footer ships four links. Three are enabled, and all three answer 404 to an anonymous visitor:

Title URI Enabled Anonymous
Privacy policy entity:node/1 yes 404
My privacy settings internal:# no not rendered
Privacy Policy internal:/privacy-policy yes 404
Terms and Conditions internal:/terms-and-conditions yes 404

What this does not fix

The footer is not clean afterwards, and it is worth stating rather than implying. The privacy page drupal_cms_privacy_basic imports is unpublished, so the surviving "Privacy policy" link still answers 404 anonymously:

SELECT nid, type, status, title FROM node_field_data WHERE title LIKE '%rivacy%'
1  page  0  Privacy policy

A recipe cannot publish content another recipe imported, because core imports default content with Existing::Skip. So that third 404 needs its own fix - publishing a privacy page this template owns and pointing the consent banner at it - and it is deliberately out of scope here.

Verification

Anonymous requests against a Varbase 11 install of this recipe, confirming each path's status and the menu rows as installed. The site used for it carries a working-copy checkout of vartheme_bs5_rightup with uncommitted changes, so it proves the menu content rather than that the branch applies against a canonical theme; nothing in this change touches the theme or any component.

No regression run yet, so that checkpoint is left unticked.

Checkpoints

  • File an issue about this project
  • Addition/Change/Update/Fix to this project
  • Testing to ensure no regression
  • Automated unit/functional testing coverage
  • Developer Documentation support on feature change/addition
  • User Guide Documentation support on feature change/addition
  • UX/UI designer responsibilities
  • Accessibility and Readability
  • Reviewed by a human
  • Code review by maintainers
  • Full testing and approval
  • Credit contributors
  • Review with the product owner
  • Update Release Notes
  • Release

AI-Generated: Yes

Edited by Rajab Natshah

Merge request reports