Resolve #3437974 "Drupal 10.3 imagestyledownloadcontrollerdeliver"

Closes #3437974

added 1 commit

• 2af52469 - Issue #3437974 by jrglasgow: Drupal 10.3 ImageStyleDownloadController::deliver signature change

Compare with previous version

marked this merge request as ready

added 1 commit

• 77a15a6a - Set required_derivative_scheme route configuration

Compare with previous version

added 1 commit

• 5ec3477b - Update image style test for webp conversion

Compare with previous version

I will note that public:// may not be the default configured scheme for a site.

This needs to take that into account and register at the appropriate path.

Thanks for the feedback. I hard-coded this based on https://git.drupalcode.org/project/remote_stream_wrapper/-/blob/61e7ff4291ddffa699512f517cf7e8ecbb44108c/src/Routing/RemoteImageStyleRoutes.php#L76 but may be misunderstanding what that is doing.

changed this line in version 4 of the diff

added 1 commit

• 2786fbf9 - Get the site default file scheme from config

Compare with previous version

I see the reason for this fix and the reasoning is good (not to assume default scheme, the developer even makes a comment to this effect), but the fix is out of scope for issue #3437974, which should just be addressing compatibility with latest Drupal 10.3

I think this is required due to the changes in the controller, but I think we could pull this out to fetch it once instead of doing it in the loop.

changed this line in version 5 of the diff

added 1 commit

• 0895b113 - Fetch default scheme outside of the loop of remote schemes.

Compare with previous version

added 1 commit

• 324fa111 - Update tests to use a newly created image style instead of a default config one.

Compare with previous version

Thanks Dave!

This looks great! Thank you Dave.

added 7 commits

• b7d6f776 - 1 commit from branch project:2.x
• 90426639 - Issue #3437974 by jrglasgow: Drupal 10.3 ImageStyleDownloadController::deliver signature change
• af6cdb71 - Set required_derivative_scheme route configuration
• bc03ca7c - Update image style test for webp conversion
• 0a991c89 - Get the site default file scheme from config
• 958fab8d - Fetch default scheme outside of the loop of remote schemes.
• a1303d01 - Update tests to use a newly created image style instead of a default config one.

Compare with previous version

merged