Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
refreshless
Manage
Activity
Members
Labels
Plan
Wiki
Custom issue tracker
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Model registry
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
project
refreshless
Commits
e0e5f1f3
Commit
e0e5f1f3
authored
5 months ago
by
ambient.impact
Browse files
Options
Downloads
Patches
Plain Diff
Issue
#3488464
: Added check to not write value prop if not visible:
This should remove the lingering custom property in various edge cases.
parent
793f8876
Branches
Branches containing commit
Tags
Tags containing commit
1 merge request
!10
Issue #3488464: Implemented our own progress bar; removed Turbo progress
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
components/progress-bar/progress-bar.js
+5
-0
5 additions, 0 deletions
components/progress-bar/progress-bar.js
with
5 additions
and
0 deletions
components/progress-bar/progress-bar.js
+
5
−
0
View file @
e0e5f1f3
...
...
@@ -304,6 +304,11 @@
*/
async
refresh
()
{
// Don't write the custom property if not visible or if currently hiding.
if
(
!
(
this
.
#visible
===
true
&&
this
.
#hiding
===
false
))
{
return
;
}
await
new
Promise
(
requestAnimationFrame
);
html
.
style
.
setProperty
(
valueCustomProperty
,
this
.
#value
);
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment