Issue #3488464: Hide progress bar sooner to fix transition performance.

a8029bee · ambient.impact · 5dec7f37 · a8029bee
Commit a8029bee authored 4 months ago by ambient.impact
--- a/modules/refreshless_turbo/js/progress_bar.js
+++ b/modules/refreshless_turbo/js/progress_bar.js
@@ -50,13 +50,19 @@
      progressBarDelay.hideVisit();
      html.removeEventListener(
-        'turbo:load', hideSuccess, {once: true},
+        'refreshless:before-render', hideSuccess, {once: true},
      )
    };
+    // We're using refreshless:before-render rather than turbo:load because the
+    // progress bar is noticeably less smoothly transitioned out when loading
+    // some complex/heavy pages on mobile in some browsers, specifically Firefox
+    // on Android. The refreshless:before-render is early enough that it should
+    // give the progress bar enough time to transition out before the new <body>
+    // contents are rendered.
    html.addEventListener(
-      'turbo:load', hideSuccess, {once: true},
+      'refreshless:before-render', hideSuccess, {once: true},
    );
    html.addEventListener(