Skip to content
Snippets Groups Projects
Commit 8142583c authored by Owen Bush's avatar Owen Bush
Browse files

Cleanup coding standards issues

parent 643a9c48
No related branches found
No related tags found
No related merge requests found
...@@ -4,5 +4,5 @@ description: Enables reminders to be sent for upcoming events. ...@@ -4,5 +4,5 @@ description: Enables reminders to be sent for upcoming events.
package: Recurring Events package: Recurring Events
core_version_requirement: ^8.9 || ^9 core_version_requirement: ^8.9 || ^9
dependencies: dependencies:
- recurring_events - recurring_events:recurring_events
- recurring_events_registration - recurring_events:recurring_events_registration
...@@ -60,7 +60,7 @@ function recurring_events_reminders_install() { ...@@ -60,7 +60,7 @@ function recurring_events_reminders_install() {
->setRequired(FALSE); ->setRequired(FALSE);
\Drupal::entityDefinitionUpdateManager() \Drupal::entityDefinitionUpdateManager()
->installFieldStorageDefinition('reminder_sent', 'eventinstance', 'eventinstance', $storage_definition); ->installFieldStorageDefinition('reminder_sent', 'eventinstance', 'eventinstance', $storage_definition);
// Set the default reminder email subject and body config. // Set the default reminder email subject and body config.
$config = \Drupal::configFactory()->getEditable('recurring_events_registration.registrant.config'); $config = \Drupal::configFactory()->getEditable('recurring_events_registration.registrant.config');
......
...@@ -7,7 +7,6 @@ ...@@ -7,7 +7,6 @@
use Drupal\Core\Field\BaseFieldDefinition; use Drupal\Core\Field\BaseFieldDefinition;
use Drupal\recurring_events_registration\Plugin\Field\ComputedRegistrantTitleFieldItemList; use Drupal\recurring_events_registration\Plugin\Field\ComputedRegistrantTitleFieldItemList;
use Drupal\Core\Config\FileStorage;
/** /**
* Install the schema updates for eventseries entities to add registration. * Install the schema updates for eventseries entities to add registration.
...@@ -389,7 +388,8 @@ function recurring_events_registration_update_8008() { ...@@ -389,7 +388,8 @@ function recurring_events_registration_update_8008() {
if (!empty($type)) { if (!empty($type)) {
$new_configs[$config_name][$type] = $config_value; $new_configs[$config_name][$type] = $config_value;
} }
} else { }
else {
$active_config->set($config_key, $config_value); $active_config->set($config_key, $config_value);
} }
} }
......
...@@ -290,7 +290,7 @@ class RegistrantSettingsForm extends ConfigFormBase { ...@@ -290,7 +290,7 @@ class RegistrantSettingsForm extends ConfigFormBase {
'#maxlength' => 180, '#maxlength' => 180,
'#states' => [ '#states' => [
'visible' => [ 'visible' => [
'input[name="' . $type .'_enabled"]' => ['checked' => TRUE], 'input[name="' . $type . '_enabled"]' => ['checked' => TRUE],
], ],
], ],
]; ];
......
...@@ -184,7 +184,8 @@ class EventSeriesForm extends ContentEntityForm { ...@@ -184,7 +184,8 @@ class EventSeriesForm extends ContentEntityForm {
$owner = $entity->getOwner(); $owner = $entity->getOwner();
if ($owner instanceof UserInterface) { if ($owner instanceof UserInterface) {
$display_name = $owner->getDisplayName(); $display_name = $owner->getDisplayName();
} else { }
else {
$entity->setOwnerId(0); $entity->setOwnerId(0);
$owner = $entity->getOwner(); $owner = $entity->getOwner();
$display_name = $owner->getDisplayName(); $display_name = $owner->getDisplayName();
......
...@@ -41,7 +41,12 @@ class RecurringEventsFieldTraitTest extends KernelTestBase { ...@@ -41,7 +41,12 @@ class RecurringEventsFieldTraitTest extends KernelTestBase {
parent::setUp(); parent::setUp();
$this->installEntitySchema('eventseries'); $this->installEntitySchema('eventseries');
$this->installEntitySchema('eventinstance'); $this->installEntitySchema('eventinstance');
$this->installConfig(['field_inheritance', 'recurring_events', 'datetime', 'system']); $this->installConfig([
'field_inheritance',
'recurring_events',
'datetime',
'system',
]);
$this->reflection = new \ReflectionClass('\Drupal\recurring_events\Plugin\RecurringEventsFieldTrait'); $this->reflection = new \ReflectionClass('\Drupal\recurring_events\Plugin\RecurringEventsFieldTrait');
} }
...@@ -66,4 +71,5 @@ class RecurringEventsFieldTraitTest extends KernelTestBase { ...@@ -66,4 +71,5 @@ class RecurringEventsFieldTraitTest extends KernelTestBase {
$this->assertEquals($expected, $result); $this->assertEquals($expected, $result);
} }
} }
} }
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment