Issue #3317546: Log successes always unticked

src/Form/RecaptchaElementSettingsForm.php

@@ -109,6 +109,7 @@ class RecaptchaElementSettingsForm extends ConfigFormBase {
     $form['logging']['log_successes'] = [
       '#type' => 'checkbox',
       '#title' => $this->t('Log successful reCAPTCHA responses'),
+      '#default_value' => $config->get('log_successes'),
       '#description' => $this->t('When checked, successful reCAPTCHA responses will be logged with log level %log_level.', [
         '%log_level' => RfcLogLevel::getLevels()[RfcLogLevel::INFO],
       ]),
@@ -134,6 +135,7 @@ class RecaptchaElementSettingsForm extends ConfigFormBase {
       ->set('site_key', $values['site_key'])
       ->set('secret_key', $values['secret_key'])
       ->set('element_defaults', $values['element_defaults'])
+      ->set('log_successes', $values['log_successes'])
       ->save();
 
     parent::submitForm($form, $form_state);

src/RecaptchaLogger.php

@@ -45,12 +45,12 @@ class RecaptchaLogger {
    *   The reCAPTCHA response to log.
    */
   public function log(ReCaptchaResponse $response) {
-    if ($response->isSuccess()) {
-      $this->logSuccess($response);
-    }
-    else {
+    if (!$response->isSuccess()) {
       $this->logFailure($response);
     }
+    elseif ($this->logSuccesses) {
+      $this->logSuccess($response);
+    }
   }
 
   /**