Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
R
range
Manage
Activity
Members
Labels
Plan
Wiki
Custom issue tracker
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Model registry
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
project
range
Commits
f08c68cf
Commit
f08c68cf
authored
4 months ago
by
Tobias Zimmermann
Browse files
Options
Downloads
Patches
Plain Diff
Remove float testing from RangeFieldUiTest
parent
794407cb
No related branches found
No related tags found
1 merge request
!19
Mark "Range (float)" field as "no_ui"
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
tests/src/Functional/RangeFieldUiTest.php
+11
-14
11 additions, 14 deletions
tests/src/Functional/RangeFieldUiTest.php
with
11 additions
and
14 deletions
tests/src/Functional/RangeFieldUiTest.php
+
11
−
14
View file @
f08c68cf
...
...
@@ -41,8 +41,8 @@ class RangeFieldUiTest extends RangeBrowserTestBase {
* Test creating range field via field UI.
*
* @param string $field_type
* Range field type. Could be one of the following values: range_integer
,
*
range_float or
range_decimal.
* Range field type. Could be one of the following values: range_integer
or
* range_decimal.
*/
protected
function
rangeTestAddNewField
(
$field_type
=
'range_integer'
)
{
$bundle_path
=
"admin/structure/types/manage/
{
$this
->
bundle
}
"
;
...
...
@@ -61,8 +61,8 @@ class RangeFieldUiTest extends RangeBrowserTestBase {
* Test range field storage settings.
*
* @param string $field_type
* Range field type. Could be one of the following values: range_integer
,
*
range_float or
range_decimal.
* Range field type. Could be one of the following values: range_integer
or
* range_decimal.
*/
protected
function
rangeTestFieldStorageSettings
(
$field_type
=
'range_integer'
)
{
$field_name
=
$this
->
getTestFieldName
(
$field_type
);
...
...
@@ -99,8 +99,8 @@ class RangeFieldUiTest extends RangeBrowserTestBase {
* Test range field settings.
*
* @param string $field_type
* Range field type. Could be one of the following values: range_integer
,
*
range_float or
range_decimal.
* Range field type. Could be one of the following values: range_integer
or
* range_decimal.
*/
protected
function
rangeTestFieldSettings
(
$field_type
=
'range_integer'
)
{
$field_name
=
$this
->
getTestFieldName
(
$field_type
);
...
...
@@ -109,7 +109,6 @@ class RangeFieldUiTest extends RangeBrowserTestBase {
switch
(
$field_type
)
{
case
'range_integer'
:
case
'range_float'
:
case
'range_decimal'
:
$this
->
assertEquals
(
$settings
[
'min'
],
$test_settings
[
'min'
],
...
...
@@ -218,8 +217,8 @@ class RangeFieldUiTest extends RangeBrowserTestBase {
* Returns storage edit array for a given field type.
*
* @param string $field_type
* Range field type. Could be one of the following values: range_integer
,
*
range_float or
range_decimal.
* Range field type. Could be one of the following values: range_integer
or
* range_decimal.
*
* @return array
* Range field storage edit array.
...
...
@@ -228,7 +227,6 @@ class RangeFieldUiTest extends RangeBrowserTestBase {
$test_settings
=
$this
->
getTestFieldStorageSettings
(
$field_type
);
switch
(
$field_type
)
{
case
'range_integer'
:
case
'range_float'
:
return
[];
case
'range_decimal'
:
...
...
@@ -245,8 +243,8 @@ class RangeFieldUiTest extends RangeBrowserTestBase {
* Returns field edit array for a given field type.
*
* @param string $field_type
* Range field type. Could be one of the following values: range_integer
,
*
range_float or
range_decimal.
* Range field type. Could be one of the following values: range_integer
or
* range_decimal.
*
* @return array
* Range field edit array.
...
...
@@ -255,7 +253,6 @@ class RangeFieldUiTest extends RangeBrowserTestBase {
$test_settings
=
$this
->
getTestFieldSettings
(
$field_type
);
switch
(
$field_type
)
{
case
'range_integer'
:
case
'range_float'
:
case
'range_decimal'
:
return
[
'settings[min]'
=>
$test_settings
[
'min'
],
...
...
@@ -278,7 +275,7 @@ class RangeFieldUiTest extends RangeBrowserTestBase {
* Tests adding range fields and their settings via field UI.
*/
public
function
testRangeFieldsUi
()
{
foreach
([
'range_integer'
,
'range_float'
,
'range_decimal'
]
as
$field_type
)
{
foreach
([
'range_integer'
,
'range_decimal'
]
as
$field_type
)
{
$this
->
rangeTestAddNewField
(
$field_type
);
$this
->
rangeTestFieldStorageSettings
(
$field_type
);
$this
->
rangeTestFieldSettings
(
$field_type
);
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment