Issue #3419132: Deprecate ConnectionFactory in 3.x
- Add
Factory\ConnectionFactory - Add
ConnectionFactory::create() - Add deprecation notices and errors
CR created here: https://www.drupal.org/node/3419104
Merge request reports
Activity
requested review from @cmlara
assigned to @cmlara
mentioned in merge request !43
@cmlara should there be any consideration to the protected methods that are going away in
5.x?added 36 commits
-
d4a75631...774634c7 - 35 commits from branch
3.x - 73ac6cd2 - Merge remote-tracking branch 'origin/3.x' into deprecate-connection-factory
-
d4a75631...774634c7 - 35 commits from branch
added 1 commit
- 9fe50e6c - Remove use of deprecated ConnectionFactory::getConnection in .install file
changed milestone to %3.2.0
-
@cmlara can i get your thoughts on this please?
I believe this is waiting on !43 to have some more work done.
For example if the new connection factory is internal we likely wouldn’t want to encourage using the replacement and would instead likely want the deprecation to state as such. Would we also need to add a shim class in that case?
-
I'm working on the remaining feedback in !43 will hopefully have it done this week!
RE the shim, while we probably will settle on
@internal, keeping the ship at least provides a safety net for those that dont heed the warning or don't have time to potentially refactor any custom solutions they might have...totally agree on the wording of the deprecation, lets strongly discourage. Keeping the shim lets us articulate our intension in the code
added 1 commit
- eabca2a5 - Improve deprecation message and include move to @internal
-
@cmlara have improved the copy here.
added 3 commits
-
44450246...625753d1 - 2 commits from branch
3.x - 4b66da12 - Merge remote-tracking branch 'origin/3.x' into deprecate-connection-factory
-
44450246...625753d1 - 2 commits from branch