Skip to content
Snippets Groups Projects

Issue 3488839: News listings/Views page is broken

Merged Rachel Jaro requested to merge issue-3488839-views-grid into 2.2.x

The views grid template is old. Removing it should fix the issue.

Merge request reports

Approval is optional

Merged by Rachel JaroRachel Jaro 2 months ago (Jan 4, 2025 1:01am UTC)

Merge details

  • Changes merged into 2.2.x with 6e65d1e0 (commits were squashed).
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • This is what is being overridden

    `{# /**

    • @file views-bootstrap-grid.html.twig
    • Default simple view template to display Bootstrap Grids.
      • columns: Contains rows grouped by columns.
      • rows: Contains a nested array of rows. Each row contains an array of
    • columns.
      • column_type: Contains a number (default Bootstrap grid system column type).
    • @ingroup views_templates */ #} {% set classes = [ 'views-view-grid', 'row' ] %} {% if title %}

    {{ title }}

    {% endif %}
    {% for row in rows %}
    { row.content }
    {% endfor %}
    `

    so from what I can tell, we were removing the "row" from the list of classes, and than added a hard coded div "

    "

    Looks like it was added a year ago when i was merging in some of the meridian things into the core provus.

    Edited by Aaron Armstrong
  • merged

Please register or sign in to reply
Loading