Skip to content
Snippets Groups Projects

3463438-updated-component-menu/Philip: Making updates to Menu Nav component

Closes #3463438

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Author Contributor

    @jldust / @pixelwhip - Based on some of the issues that I ran into using the Menu component on Wu Tsai, I've formulated a workable solution, as well as cleaned up some unnecessary code and files.

    I think we should rename the menu component to menu-nav, along with all associated classes.

    I've ran this through Michaela for A11Y testing with success.

    I've also used this on both an abnormally structured menu (with divs as dropdowns), as well as a basically structured menu (with uls as dropdowns) with success.

  • Philip Stier added 1 commit

    added 1 commit

    • df037b70 - 3463438-updated-component-menu/Philip: Fix to keyboard getting stuck on mobile

    Compare with previous version

  • Author Contributor

    @jldust / @pixelwhip - A11Y audit pointed out getting stuck within mobile menus, which has now been fixed :smile:

Please register or sign in to reply
Loading