Skip to content
Snippets Groups Projects

Resolve #3511080 "Officially define our"

5 unresolved threads

Closes #3511080

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
6 6
7 7 /**
8 8 * Defines the possible states of a project in the current site.
9 *
10 * @api
11 * This enum is covered by our backwards compatibility promise and can be
12 * safely relied upon.
  • Adam G-H added 1 commit

    added 1 commit

    • 0dc98fcc - Make all classes in pb_test final

    Compare with previous version

  • 51 50 * '#page_sizes' => [5, 10, 25],
    52 51 * ];
    53 52 * @endcode
    53 *
    54 * @internal
    55 * This is an internal part of Project Browser and may be changed or removed
    56 * at any time. It should not be used by external code.
    54 57 */
    55 58 #[RenderElement('project_browser')]
    56 final class ProjectBrowser implements ElementInterface, ContainerFactoryPluginInterface {
    59 final class ProjectBrowser extends RenderElementBase implements ContainerFactoryPluginInterface {
    • Author Contributor

      We only ever needed to implement ElementInterface as a shim for supporting Drupal 10.2 and earlier. Now that we don't, we can use this base class safely.

    • Please register or sign in to reply
  • 8 8 * The different project types known to Project Browser.
    9 9 *
    10 10 * @see \Drupal\project_browser\ProjectBrowser\Project
    11 *
    12 * @api
    13 * This enum is covered by our backwards compatibility promise and can be
    14 * safely relied upon.
  • 8 8
    9 9 /**
    10 10 * Trait used by UI tests for testing actions like clicking and dragging.
    11 *
    12 * @internal
    13 * This is an internal part of Project Browser and may be changed or removed
    14 * at any time. It should not be used by external code.
  • 1 svelte:
    1 app:
    • Author Contributor

      Now's the time to rename this library. svelte couples the library name to the assumption that it's written in Svelte (it's also just a very unintuitive name for the library), so we'd have to do a whole deprecation dance if we ever decided to rewrite the frontend in, say, React. Since the frontend is internal, we don't want to couple the name to its implementation.

    • Please register or sign in to reply
  • Adam G-H added 1 commit

    added 1 commit

    • b6493ced - Make a few protected methods private

    Compare with previous version

  • Adam G-H added 5 commits

    added 5 commits

    Compare with previous version

  • Adam G-H added 1 commit

    added 1 commit

    • 1e38f8c7 - Make RecieActivator a non-public service

    Compare with previous version

  • Adam G-H added 1 commit

    added 1 commit

    • 2724f95a - Undo that, fix misnamed test

    Compare with previous version

  • Tim Plunkett added 8 commits

    added 8 commits

    • 44ab29c9 - 1 commit from branch project:2.0.x
    • 7c917317 - Make all classes final and define them as either API or internal
    • c1fb699d - Make all tests final and the test traits internal
    • 684cebc0 - Rename libraries
    • 7f72b47c - Make all classes in pb_test final
    • 2cafc3ba - Make a few protected methods private
    • 11432bf0 - Make RecieActivator a non-public service
    • 7d90030c - Undo that, fix misnamed test

    Compare with previous version

  • merged

  • Please register or sign in to reply
    Loading