#3505700: Move the Project browser specific styling from gin theme to project browser's scope.
Closes #3505700
Merge request reports
Activity
19 19 css: 20 20 theme: 21 21 css/pb.css: {} 22 css/project_browser_gin.css: {} changed this line in version 2 of the diff
added 13 commits
-
b6959028...df2c860c - 11 commits from branch
project:2.0.x - 290403db - Conditionally adding the gin theme csss
- 72c1d3b1 - Merge branch '2.0.x' into 3505700-move-the-project
-
b6959028...df2c860c - 11 commits from branch
added 5 commits
-
107ef446...2e63ded7 - 4 commits from branch
project:2.0.x - 9bbf3041 - Merge branch '2.0.x' into 3505700-move-the-project
-
107ef446...2e63ded7 - 4 commits from branch
added 4 commits
-
9bbf3041...2939e3cc - 2 commits from branch
project:2.0.x - 9032540f - Addressed feedbacks
- c46a1831 - Merge branch '2.0.x' into 3505700-move-the-project
-
9bbf3041...2939e3cc - 2 commits from branch
65 65 * {@inheritdoc} 66 66 */ 67 67 public function getInfo(): array { 68 $libraries = ['project_browser/svelte']; 69 if (\Drupal::theme()->getActiveTheme()->getName() === 'gin') { 70 $libraries[] = 'project_browser/project_browser_gin'; changed this line in version 8 of the diff
65 65 * {@inheritdoc} 66 66 */ 67 67 public function getInfo(): array { 68 $libraries = ['project_browser/svelte']; 69 if (\Drupal::theme()->getActiveTheme()->getName() === 'gin') { -
Any chance you can inject this?
Also, this is in the element info, which is cached because it is a plugin definition. I'd rather this was attached dynamically at render time, so this should not be happening in
getInfo().Edited by Adam G-H changed this line in version 8 of the diff
css/gin.css 0 → 1006441 /* cspell:ignore xxxs */ 2 #project-browser .search__form-container, -
We just had an issue to get rid of #project-browser as a selector. Do we need to do that here, or in a follow up, or not do it at all?
(I'm unsure why using
#project-browseras a selector is a bad idea, or if it really is, other than that it's a heavy hitter in the specificity department.) 
@cwells @phenaproxima agreed, most of the styling provided here could be carried over to the general PB styling and in
gin.csswe'd only map CSS variables from PB to Gin to make spacing, accent color and darkmode workingSee e.g. what we do for
navigation:https://git.drupalcode.org/project/gin/-/blob/4.0.x/styles/navigation/variables.scss?ref_type=heads
-
Opened https://www.drupal.org/project/project_browser/issues/3509162 for that!
added 6 commits
- df809ed2 - Issue #3477335: Follow-up; Update core.phpcs.xml.dist
- 8b49781d - Issue #3506377 by arunsahijpal, narendrar, phenaproxima, fjgarlin: Warning:...
- c0bac1ea - Issue #3508182 by zaporylie, narendrar: Update documentation with accurate version string
- bfcd779b - Issue #3506557: Provide a follow-up task to uninstall a module
- a8b0227f - Issue #3508090 by phenaproxima, tim.plunkett: Add assertElementIsVisible() as...
- ea7713f7 - Issue #3507922 by phenaproxima, tim.plunkett: Add assertPageHasText() as a...
Toggle commit listadded 13 commits
-
ea7713f7...579a4072 - 11 commits from branch
project:2.0.x - 2ed6a3ae - Merge branch '2.0.x' into 3505700-move-the-project
- e54cd11d - Merge branch '3505700-move-the-project' of...
-
ea7713f7...579a4072 - 11 commits from branch
added 7 commits
-
c544a5b4...c797ee9f - 6 commits from branch
project:2.0.x - b4948ebe - Merge branch '2.0.x' into 3505700-move-the-project
-
c544a5b4...c797ee9f - 6 commits from branch
added 5 commits
-
b4948ebe...7401da78 - 3 commits from branch
project:2.0.x - 0f4306e7 - Merge branch '2.0.x' into 3505700-move-the-project
- f5edfe6f - Conflict with Gin
-
b4948ebe...7401da78 - 3 commits from branch
