#3498562: The styling of the new installed button is not inline in light and broken in dark mode
Merged
#3498562: The styling of the new installed button is not inline in light and broken in dark mode
3 unresolved threads
3 unresolved threads
Closes #3498562
Merge request reports
Activity
added 8 commits
-
d6dc60f3...8cb9687c - 5 commits from branch
project:2.0.x
- 53593817 - Replacing the green icon when in dark mode
- 58950852 - Added icon
- 12bfd979 - Merging 2.0.x
Toggle commit list-
d6dc60f3...8cb9687c - 5 commits from branch
58 58 <ProjectStatusIndicator {project} statusText={Drupal.t('Not compatible')} /> 59 59 {:else if project.status === 'active'} 60 60 <ProjectStatusIndicator {project} statusText={Drupal.t('Installed')}> 61 {#if ('gin' in drupalSettings && drupalSettings.gin.darkmode === '1')} 62 <ProjectIcon type="greenInstalled" /> Opened https://www.drupal.org/project/project_browser/issues/3503137 for this.
1 1 <script> 2 2 export let project; 3 3 export let statusText; 4 let buttonClasses = ''; 5 let buttonLabelClasses = ''; 4 6 5 7 const { Drupal } = window; 8 $: { 9 // @see css/pb.css 10 if ('gin' in drupalSettings && drupalSettings.gin.darkmode === '1') { This could be in a follow-up, but we probably don't want to tie this to Gin. I think what we might want to do is move the setting to
drupalSettings.project_browser.darkMode
(and expose it as a constant inconstants.js
) so that we can generically handle dark mode, rather than only Gin's dark mode.Opened https://www.drupal.org/project/project_browser/issues/3503140 for this.
added 5 commits
-
b48fc063...31756465 - 4 commits from branch
project:2.0.x
- 0c837df7 - Merge branch '2.0.x' into 3498562-the-styling-of
-
b48fc063...31756465 - 4 commits from branch
Please register or sign in to reply