Skip to content
Snippets Groups Projects

Remove activeTab entirely

Merged Remove activeTab entirely
issue/project_browser-3501766:3501766-remove-activetab-from into 2.0.x
1 unresolved thread
Merged Adam G-H requested to merge issue/project_browser-3501766:3501766-remove-activetab-from into 2.0.x
1 unresolved thread

Closes #3501766

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
sveltejs/src/ProjectBrowser.svelte
178 180 pageSize.set(Number(savedPageSize));
179 181 }
180 182
181 $activeTab = DEFAULT_SOURCE_ID;
182 183 // The project ID, if there is one, will be the last thing in the URL
  • Chris Wells
    Chris Wells @cwells
    Maintainer

    All of this code looks like it's related to the bad assumption stated in the comments. Do we actually have URLs that end in a project ID now that the project detail pages open in a modal? I fear we're just rearranging deck chairs on the Titanic here.

  • Adam G-H
    Adam G-H @phenaproxima
    Author Contributor

    You're not wrong. This code is so tangled up that we really need to take it one small step at a time. "Eliminating unnecessary variables" is the stage we're currently in, as that will make the actual core logic more grokable. It's a really long game we're playing here.

  • Chris Wells
    Chris Wells @cwells
    Maintainer

    Fair, then I'm comfortable going as-is since this is baby steps. It might be nice to leave "future us" a comment/@todo here tho.

  • Adam G-H changed this line in version 2 of the diff

    changed this line in version 2 of the diff

  • Please register or sign in to reply
  • Chris Wells resolved all threads

    resolved all threads

  • Adam G-H added 1 commit

    added 1 commit

    • 37564317 - Fix wrong assignment of queueList

    Compare with previous version

  • Chris Wells merged

    merged

    • Please register or sign in to reply