Skip to content
Snippets Groups Projects

Resolve #3489054 "Add to cart threshold"

Closes #3489054

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
38 38 '#type' => 'project_browser',
39 39 '#source' => $source,
40 40 '#id' => $id,
41 // @todo Make below line configurable.
42 '#max_selections' => 1,
  • We can remove the todo. This is already "configurable" in the sense that you can pass it to the render element.

  • We need to default this to NULL. If Drupal CMS wants it different, it should alter the element. Open to discussion but I still feel that for PB standalone it's a superior experience to have multiples.

    I would also accept, for now, some kinds of "if $source == 'recipes' #max_selections = 1" but my hunch is Drupal CMS would prefer to change it globally.

  • If Drupal CMS can't provide its own code, let's make it a config setting. We don't need to have it in the UI (yet, or maybe ever) since it would be better to make this a per-instance setting anyway (ex.g. "mini-browser")

  • Adam G-H changed this line in version 21 of the diff

    changed this line in version 21 of the diff

  • Please register or sign in to reply
  • added 1 commit

    • 63b55f7f - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • added 3 commits

    • c5eb4cb4 - Some feedback addressed
    • 037c0873 - Reverted unnecessary changes
    • 5f48c46c - Code refactored for ProcessQueueButton

    Compare with previous version

  • Narendra Singh Rathore resolved all threads

    resolved all threads

  • Adam G-H
  • added 1 commit

    Compare with previous version

  • Narendra Singh Rathore resolved all threads

    resolved all threads

  • added 1 commit

    Compare with previous version

  • added 12 commits

    Compare with previous version

  • Narendra Singh Rathore resolved all threads

    resolved all threads

  • added 1 commit

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • utkarsh_33 added 1 commit

    added 1 commit

    • c4a932e0 - Fixed drupal.t() usage and buttons toggle issue

    Compare with previous version

  • Narendra Singh Rathore resolved all threads

    resolved all threads

  • utkarsh_33 added 3 commits

    added 3 commits

    Compare with previous version

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading