Skip to content
Snippets Groups Projects

#3464450: "Certain filters should"

Merge request reports

Checking pipeline status.

Merged by Chris WellsChris Wells 8 months ago (Sep 5, 2024 2:01pm UTC)

Loading

Pipeline #274726 failed

Pipeline failed for 96223a14 on 2.0.x

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
2 2 import { writable } from 'svelte/store';
3 3
4 4 import {
5 DEFAULT_SOURCE_ID, SORT_OPTIONS,
5 DEFAULT_SOURCE_ID, SORT_OPTIONS, FILTERS,
6 6 } from './constants';
7 7
8 // Store the selected tab.
9 const storedActiveTab = JSON.parse(sessionStorage.getItem('activeTab')) || DEFAULT_SOURCE_ID;
10 let activeFilters = [];
11 if (Object.keys(FILTERS).length > 0 && storedActiveTab in FILTERS) {
  • 2 2 import { writable } from 'svelte/store';
    3 3
    4 4 import {
    5 DEFAULT_SOURCE_ID, SORT_OPTIONS,
    5 DEFAULT_SOURCE_ID, SORT_OPTIONS, FILTERS,
    6 6 } from './constants';
    7 7
    8 // Store the selected tab.
    9 const storedActiveTab = JSON.parse(sessionStorage.getItem('activeTab')) || DEFAULT_SOURCE_ID;
    10 let activeFilters = [];
    11 if (Object.keys(FILTERS).length > 0 && storedActiveTab in FILTERS) {
    12 activeFilters = FILTERS[storedActiveTab];
    13 }
    14 export const sourceFilters = writable(activeFilters);
  • 446 446 $this->assertEquals($results_before, $results_after);
    447 447 }
    448 448
    449 /**
    450 * Tests filters are displayed if they are defined by source.
    451 */
    452 public function testFiltersShownIfDefinedBySource(): void {
    453 $assert_session = $this->assertSession();
    454 $this->config('project_browser.admin_settings')
    455 ->set('enabled_sources', ['recipes'])
    456 ->save();
    457 $this->drupalGet('admin/modules/browse');
    458
    459 // Recipes doesn't define any filters so no filters are displayed.
    460 $this->assertNULL($assert_session->waitForElementVisible('css', 'search__form-filters-container'));
  • 455 ->set('enabled_sources', ['recipes'])
    456 ->save();
    457 $this->drupalGet('admin/modules/browse');
    458
    459 // Recipes doesn't define any filters so no filters are displayed.
    460 $this->assertNULL($assert_session->waitForElementVisible('css', 'search__form-filters-container'));
    461
    462 // Enable module for extra source plugin.
    463 $this->container->get('module_installer')->install(['project_browser_devel']);
    464 $this->config('project_browser.admin_settings')->set('enabled_sources', ['drupalorg_mockapi'])->save(TRUE);
    465
    466 $this->drupalGet('admin/modules/browse');
    467 // Drupal.org mockapi defines only two filters (actively maintained filter
    468 // and security coverage filter).
    469 // @see \Drupal\project_browser\Plugin\ProjectBrowserSource\MockDrupalDotOrg::getFilterDefinitions()
    470 $this->assertTrue($assert_session->waitForText('Maintenance Status'));
  • 463 $this->container->get('module_installer')->install(['project_browser_devel']);
    464 $this->config('project_browser.admin_settings')->set('enabled_sources', ['drupalorg_mockapi'])->save(TRUE);
    465
    466 $this->drupalGet('admin/modules/browse');
    467 // Drupal.org mockapi defines only two filters (actively maintained filter
    468 // and security coverage filter).
    469 // @see \Drupal\project_browser\Plugin\ProjectBrowserSource\MockDrupalDotOrg::getFilterDefinitions()
    470 $this->assertTrue($assert_session->waitForText('Maintenance Status'));
    471 $assert_session->waitForElementVisible('css', self::MAINTENANCE_OPTION_SELECTOR);
    472 $this->assertTrue($assert_session->waitForText('Security Advisory Coverage'));
    473 $assert_session->waitForElementVisible('css', self::SECURITY_OPTION_SELECTOR);
    474 // Make sure no other filters are displayed.
    475 $this->assertFalse($assert_session->waitForText('Development Status'));
    476 $this->assertNull($assert_session->waitForElementVisible('css', self::DEVELOPMENT_OPTION_SELECTOR));
    477 $this->assertFalse($assert_session->waitForText('Filter by category'));
    478 $this->assertNull($assert_session->waitForElementVisible('css', 'div.search__form-filters-container > div.search__form-filters > section > fieldset > div'));
  • Kunal Sachdev added 1 commit

    added 1 commit

    Compare with previous version

  • Kunal Sachdev added 1 commit

    added 1 commit

    • 78d4e63a - address feedback regarding test

    Compare with previous version

  • Kunal Sachdev added 1 commit

    added 1 commit

    • 96b695e9 - allow test to decide which filters are defined by the source mockapi

    Compare with previous version

  • Kunal Sachdev added 1 commit

    added 1 commit

    Compare with previous version

  • Kunal Sachdev added 28 commits

    added 28 commits

    Compare with previous version

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading