Fix Drupal.Arrays.Array.LongLineDeclaration
2 open threads
This change only fixes PHPCS warnings relating to long lines. Closes #3419925
Merge request reports
Activity
added 1 commit
- 299305d4 - Fix PHPCS Drupal.Arrays.Array.LongLineDeclaration
453 453 $project['body']['summary'] = Xss::filter(strip_tags($project['body']['summary'])); 454 454 $project['body']['summary'] = Unicode::truncate($project['body']['summary'], 200, TRUE, TRUE); 455 455 456 // Once we hit projects that haven't been updated since March 13, 2020, we 457 // know they aren't compatible because it is before 456 // Once we hit projects that haven't been updated since March 13, 2020, 457 // we know they aren't compatible because it is before 458 458 // https://www.drupal.org/node/3119415. - Comment on lines +456 to 458
Note this is in a function called "hackyFixtureMaker". As far as I can tell, this pulls pages of projects from drupal.org, sorted by last updated, and when it "hits" the 2020-03-13, it knows it doesn't need to go further because that's when the "core" directive in .info.yml was deprecated.
I think "find" implies a search rather than a scan. How about "reach"?
changed this line in version 10 of the diff
added 1 commit
- a194fd6a - Applying improvements suggested by quietone.
added 1 commit
- d0320cc3 - Added phpcs:ignore for blank line after cspell.
added 1 commit
- 6f64cf07 - Add phpcs ignore for blank line after cspell exceptions.
added 15 commits
-
41bf4dcb - 1 commit from branch
project:1.0.x - 41bf4dcb...d50896a9 - 4 earlier commits
- 1f97c066 - Adding long line array I missed.
- 67ec72f8 - Ignore missing punctuation on command.
- e50184e1 - Correct phpcs:ignore.
- cd26b928 - Restore blank line after cspell:ignore.
- d3e9c2c3 - Added phpcs:ignore for blank line after cspell.
- 21c1d903 - Comment fixes.
- fa735a87 - Comment fixes.
- addb88f2 - Add phpcs ignore for blank line after cspell exceptions.
- e6ebf4a2 - Comment issues.
- 71cf497d - Move cspell below use statements.
Toggle commit list-
41bf4dcb - 1 commit from branch
added 8 commits
-
1ca27deb...3ac3ea1b - 7 commits from branch
project:1.0.x - 0886fc0c - Merge branch '1.0.x' into '3419925-gitlab-ci--' - removes getters and setters from previous issue
-
1ca27deb...3ac3ea1b - 7 commits from branch
453 453 $project['body']['summary'] = Xss::filter(strip_tags($project['body']['summary'])); 454 454 $project['body']['summary'] = Unicode::truncate($project['body']['summary'], 200, TRUE, TRUE); 455 455 456 // Once we hit projects that haven't been updated since March 13, 2020, 457 // we know they aren't compatible because it is before 458 // https://www.drupal.org/node/3119415. 456 // Once we reach projects that haven't been updated since 2020-03-13, we 457 // know they aren't compatible because it is before deprecation of code 458 // directive in .info.yml file. 459 // @see https://www.drupal.org/node/3119415 - Comment on lines +456 to +459
I think this is referring to the deprecation of the 'core' key, not the 'code directive'. What do you think of this re-wording?
456 // Once we reach projects that haven't been updated since 2020-03-13, we 457 // know they aren't compatible because it is before deprecation of code 458 // directive in .info.yml file. 459 // @see https://www.drupal.org/node/3119415 456 // Projects there were last updated before 2020-03-13 are not 457 // compatible. That is date of the deprecation of the 'core' key from 458 // the info.yml file. 459 // @see https://www.drupal.org/node/3119415
added 1 commit
- bb13f005 - Clarify description for excluded deprecated projects.
added 19 commits
-
bb13f005...4995c82d - 2 commits from branch
project:1.0.x - 4995c82d...2893e220 - 7 earlier commits
- 651fda1d - Restore blank line after cspell:ignore.
- 8fa5ae58 - Added phpcs:ignore for blank line after cspell.
- fcf4b849 - Comment fixes.
- 28b6fc73 - Comment fixes.
- 4eee5d08 - Add phpcs ignore for blank line after cspell exceptions.
- 4f7dcac7 - Comment issues.
- c82783d0 - Move cspell below use statements.
- 8c27dd73 - Initial CSS fixes.
- 49454329 - Revert "Initial CSS fixes."
- 7c012dc3 - Clarify description for excluded deprecated projects.
Toggle commit list-
bb13f005...4995c82d - 2 commits from branch
Please register or sign in to reply