Issue #3499411: After composer error on install, card incorrectly reflects "Installed" status

sveltejs/src/QueueProcessor.js

@@ -48,6 +48,10 @@ export const handleError = async (errorResponse) => {
   } else {
     div.innerHTML += `<p>${errorMessage}</p>`;
   }
+  const currentQueueList = get(queueList) || [];
+  for (const project of currentQueueList) {
+    project.error = errorMessage;
+  }
 
   openPopup(div, { title: 'Error while installing package(s)' });
 };
@@ -196,6 +200,8 @@ export const processQueue = async () => {
 
   clearQueue();
   for (const project of currentQueueList) {
-    project.status = 'active';
+    if(!project.error) {
+      project.status = 'active';
+    }
   }
 };

tests/src/FunctionalJavascript/ProjectBrowserInstallerUiTest.php

@@ -485,4 +485,31 @@ class ProjectBrowserInstallerUiTest extends WebDriverTestBase {
     $this->assertTrue($was_selected);
   }
 
+  /**
+   * Tests that the install state does not change on error.
+   */
+  public function testInstallStatusUnchangedOnError(): void {
+    $assert_session = $this->assertSession();
+    $page = $this->getSession()->getPage();
+
+    // Start install begin.
+    $this->drupalGet('admin/modules/project_browser/install-begin', [
+      'query' => ['source' => 'project_browser_test_mock'],
+    ]);
+    $this->drupalGet('admin/modules/browse/project_browser_test_mock');
+    $this->svelteInitHelper('text', 'Cream cheese on a bagel');
+    // Try beginning another install while one is in progress, but not yet in
+    // the applying stage.
+    $cream_cheese_module_selector = '#project-browser .pb-layout__main ul > li:nth-child(1)';
+    $cream_cheese_button = $page->find('css', "$cream_cheese_module_selector button.pb__action_button");
+    $cream_cheese_button?->click();
+    // Close the dialog to assert the state of install button.
+    $page->find('css', '.ui-dialog-titlebar-close')?->click();
+    $download_button = $assert_session->waitForElementVisible('css', "$cream_cheese_module_selector button.pb__action_button");
+    $this->assertNotEmpty($download_button);
+    // Assertion that the install state does not change.
+    $this->assertSame('Install Cream cheese on a bagel', $download_button->getText());
+
+  }
+
 }