Issue #3477232 by phenaproxima, fjgarlin, chrisfromredfin, omkar-pd,...

Issue #3477232 by phenaproxima, fjgarlin, chrisfromredfin, omkar-pd, lostcarpark: Project detail page: "link to drupal.org" should be provided by the backend plugin

src/Plugin/ProjectBrowserSource/DrupalDotOrgJsonApi.php

@@ -6,6 +6,7 @@ use Drupal\Component\Serialization\Json;
 use Drupal\Component\Utility\Html;
 use Drupal\Core\Extension\ExtensionVersion;
 use Drupal\Core\StringTranslation\StringTranslationTrait;
+use Drupal\Core\Url;
 use Drupal\project_browser\DevelopmentStatus;
 use Drupal\project_browser\MaintenanceStatus;
 use Drupal\project_browser\Plugin\ProjectBrowserSourceBase;
@@ -396,6 +397,7 @@ class DrupalDotOrgJsonApi extends ProjectBrowserSourceBase {
           packageName: $project['attributes']['field_composer_namespace'] ?? 'drupal/' . $machine_name,
           categories: $module_categories,
           images: $project_images,
+          url: Url::fromUri('https://www.drupal.org/project/' . $machine_name),
         );
         $returned_list[] = $project_object;
       }

src/Plugin/ProjectBrowserSource/Recipes.php

@@ -13,6 +13,7 @@ use Drupal\Core\Extension\ModuleExtensionList;
 use Drupal\Core\File\FileSystemInterface;
 use Drupal\Core\File\FileUrlGeneratorInterface;
 use Drupal\Core\Recipe\Recipe;
+use Drupal\Core\Url;
 use Drupal\project_browser\Plugin\ProjectBrowserSourceBase;
 use Drupal\project_browser\ProjectBrowser\Project;
 use Drupal\project_browser\ProjectBrowser\ProjectsResultsPage;
@@ -81,6 +82,10 @@ class Recipes extends ProjectBrowserSourceBase {
           $package = file_get_contents($path . '/composer.json');
           $package = Json::decode($package);
           $package_name = $package['name'];
+
+          if (array_key_exists('homepage', $package)) {
+            $url = Url::fromUri($package['homepage']);
+          }
         }
 
         $recipe = Yaml::decode($file->getContents());
@@ -110,6 +115,7 @@ class Recipes extends ProjectBrowserSourceBase {
           author: [],
           packageName: $package_name,
           type: ProjectType::Recipe,
+          url: $url ?? NULL,
         );
       }
       $this->cacheBin->set($this->getPluginId(), $projects);

src/ProjectBrowser/Project.php

@@ -94,8 +94,8 @@ class Project implements \JsonSerializable {
    *   Author of the project in array format.
    * @param string $packageName
    *   The Composer package name of this project, e.g. `drupal/project_browser`.
-   * @param string $url
-   *   URL of the project.
+   * @param \Drupal\Core\Url|null $url
+   *   URL of the project, if any. Defaults to NULL.
    * @param array $categories
    *   Value of module_categories of the project.
    * @param array $images
@@ -127,7 +127,7 @@ class Project implements \JsonSerializable {
     public int $created,
     public array $author,
     public string $packageName,
-    public string $url = '',
+    public ?Url $url = NULL,
     public array $categories = [],
     public array $images = [],
     public array $warnings = [],
@@ -212,7 +212,7 @@ class Project implements \JsonSerializable {
       'is_maintained' => $this->isMaintained,
       'is_active' => $this->isActive,
       'flag_project_star_user_count' => $this->starUserCount,
-      'url' => $this->url,
+      'url' => $this->url?->setAbsolute()->toString(),
       'status' => match ($this->status) {
         ActivationStatus::Absent => 'absent',
         ActivationStatus::Present => 'present',

sveltejs/src/ModulePage.svelte

@@ -115,17 +115,6 @@
       </div>
     {/if}
 
-    {#if project.project_machine_name}
-      <div
-        class="pb-module-page__view-commands pb-module-page__sidebar_element"
-      >
-        <button
-          class="project__action_button"
-          onclick="window.location.href='https://drupal.org/project/{project.project_machine_name}';"
-          >View on Drupal.org</button
-        >
-      </div>
-    {/if}
     {#if project.url}
       <div
         class="pb-module-page__view-commands pb-module-page__sidebar_element"
@@ -133,7 +122,7 @@
         <button
           class="project__action_button"
           onclick="window.location.href='{project.url}';"
-          >View on Drupal.org</button
+          >{Drupal.t('Learn more')}</button
         >
       </div>
     {/if}

tests/modules/project_browser_test/src/Plugin/ProjectBrowserSource/ProjectBrowserTestMock.php

@@ -8,6 +8,7 @@ use Drupal\Core\Cache\CacheBackendInterface;
 use Drupal\Core\Database\Connection;
 use Drupal\Core\Extension\ModuleHandlerInterface;
 use Drupal\Core\State\StateInterface;
+use Drupal\Core\Url;
 use Drupal\project_browser\DevelopmentStatus;
 use Drupal\project_browser\MaintenanceStatus;
 use Drupal\project_browser\Plugin\ProjectBrowserSourceBase;
@@ -421,7 +422,7 @@ class ProjectBrowserTestMock extends ProjectBrowserSourceBase {
           created: $project_data['created'],
           author: ['name' => $project_data['author']],
           packageName: 'drupal/' . $project_data['field_project_machine_name'],
-          url: 'https://www.drupal.org/project/' . $project_data['field_project_machine_name'],
+          url: Url::fromUri('https://www.drupal.org/project/' . $project_data['field_project_machine_name']),
           // Add name property to each category, so it can be rendered.
           categories: array_map(fn($category) => $categories[$category['id']] ?? '', $project_data['project_data']['taxonomy_vocabulary_3'] ?? []),
           images: $project_data['project_data']['field_project_images'] ?? [],