Issue #3503137: The ProjectIcon component should accept an image prop, or...

Issue #3503137: The ProjectIcon component should accept an image prop, or figure out its image internally

sveltejs/src/Project/ActionButton.svelte

@@ -15,7 +15,6 @@
 
   // eslint-disable-next-line import/no-mutable-exports,import/prefer-default-export
   export let project;
-  const drupalSetting = drupalSettings;
 
   const { Drupal } = window;
   const processMultipleProjects = MAX_SELECTIONS === null || MAX_SELECTIONS > 1;
@@ -59,11 +58,7 @@
     <ProjectStatusIndicator {project} statusText={Drupal.t('Not compatible')} />
   {:else if project.status === 'active'}
     <ProjectStatusIndicator {project} statusText={Drupal.t('Installed')}>
-      {#if 'gin' in drupalSetting && drupalSetting.gin.darkmode === '1'}
-        <ProjectIcon type="greenInstalled" />
-      {:else}
-        <ProjectIcon type="installed" />
-      {/if}
+      <ProjectIcon type="installed" />
     </ProjectStatusIndicator>
   {:else}
     <span>

sveltejs/src/Project/ProjectIcon.svelte

 <script>
   import { FULL_MODULE_PATH, DARK_COLOR_SCHEME } from '../constants';
 
-  const { Drupal } = window;
-  // eslint-disable-next-line import/no-mutable-exports,import/prefer-default-export
+  const { Drupal, drupalSettings } = window;
+
   export let type = '';
   export let variant = false;
   export let classes = false;
@@ -37,18 +37,22 @@
       alt: Drupal.t('Installed'),
       title: Drupal.t('This project is installed.'),
     },
-    greenInstalled: {
-      path: 'green-checkmark-icon',
-      alt: Drupal.t('Installed'),
-      title: Drupal.t('This module is installed.'),
-    },
   };
+  const { alt, title } = typeToImg[type];
+  let { path } = typeToImg[type];
+  if (
+    'gin' in drupalSettings &&
+    drupalSettings.gin.darkmode === '1' &&
+    type === 'installed'
+  ) {
+    path = 'green-checkmark-icon';
+  }
 </script>
 
 {#if type === 'installed'}
-  <span class="pb-project__status-icon-span" title={typeToImg[type].title}>
+  <span class="pb-project__status-icon-span" {title}>
     <img
-      src="{FULL_MODULE_PATH}/images/{typeToImg[type].path}{DARK_COLOR_SCHEME
+      src="{FULL_MODULE_PATH}/images/{path}{DARK_COLOR_SCHEME
         ? '--dark-color-scheme'
         : ''}.svg"
       class={`pb-icon pb-icon--${variant} pb-icon--${type} ${classes}`}
@@ -62,7 +66,7 @@
         ? '--dark-color-scheme'
         : ''}.svg"
       class={`pb-icon pb-icon--${variant} pb-icon--${type} ${classes}`}
-      alt={typeToImg[type].alt}
+      {alt}
     />
   </button>
 {/if}