Issue #3497909 by utkarsh_33, uttam, phenaproxima, narendrar, omkar-pd: Remove...

Issue #3497909 by utkarsh_33, uttam, phenaproxima, narendrar, omkar-pd: Remove the word "queue" from the Svelte code

sveltejs/src/QueueProcessor.js → sveltejs/src/InstallListProcessor.js

@@ -4,11 +4,11 @@ import { BASE_URL, CURRENT_PATH } from './constants';
 
 export const updated = writable(0);
 
-// Store for the queue list.
-export const queueList = writable([]);
+// Store for the install list.
+export const installList = writable([]);
 
-export function addToQueue(project) {
-  queueList.update((currentList) => {
+export function addToInstallList(project) {
+  installList.update((currentList) => {
     if (!currentList.includes(project)) {
       currentList.push(project);
     }
@@ -16,8 +16,8 @@ export function addToQueue(project) {
   });
 }
 
-export function removeFromQueue(projectId) {
-  queueList.update((currentList) => {
+export function removeFromInstallList(projectId) {
+  installList.update((currentList) => {
     currentList = currentList.filter(
       (item) => item.id !== projectId,
     );
@@ -25,8 +25,8 @@ export function removeFromQueue(projectId) {
   });
 }
 
-export function clearQueue() {
-  queueList.update((currentList) => {
+export function clearInstallList() {
+  installList.update((currentList) => {
     currentList = [];
     return currentList;
   });
@@ -77,8 +77,8 @@ export const handleError = async (errorResponse) => {
   } else {
     div.innerHTML += `<p>${errorMessage}</p>`;
   }
-  const currentQueueList = get(queueList) || [];
-  for (const project of currentQueueList) {
+  const currentInstallList = get(installList) || [];
+  for (const project of currentInstallList) {
     project.error = errorMessage;
   }
 
@@ -198,17 +198,17 @@ export const doRequests = async (projectIds) => {
   }
 };
 
-export const processQueue = async () => {
-  const currentQueueList = get(queueList) || [];
+export const processInstallList = async () => {
+  const currentInstallList = get(installList) || [];
   const projectsToActivate = [];
   const projectsToDownloadAndActivate = [];
-  if (currentQueueList.length === 0) {
+  if (currentInstallList.length === 0) {
     new Drupal.Message().add(Drupal.t('No projects selected'), { type: 'error' });
     window.scrollTo({ top: 0, behavior: 'smooth' });
     return;
   }
 
-  for (const proj of currentQueueList) {
+  for (const proj of currentInstallList) {
     if (proj.status === 'absent') {
       projectsToDownloadAndActivate.push(proj.id);
     } else if (proj.status === 'present') {
@@ -227,8 +227,8 @@ export const processQueue = async () => {
 
   document.body.style.pointerEvents = 'auto';
 
-  clearQueue();
-  for (const project of currentQueueList) {
+  clearInstallList();
+  for (const project of currentInstallList) {
     if(!project.error) {
       project.status = 'active';
     }

sveltejs/src/ProcessQueueButton.svelte → sveltejs/src/ProcessInstallListButton.svelte

 <script>
   import {
-    processQueue,
-    queueList,
+    processInstallList,
+    installList,
     updated,
-    clearQueue,
-  } from './QueueProcessor';
+    clearInstallList,
+  } from './InstallListProcessor';
   import Loading from './Loading.svelte';
   import LoadingEllipsis from './Project/LoadingEllipsis.svelte';
 
@@ -14,14 +14,14 @@
   let buttonClasses;
   let bulkActionClasses = '';
 
-  $: currentQueueList = $queueList || [];
-  $: queueLength = currentQueueList.length;
+  $: currentInstallList = $installList || [];
+  $: installListLength = currentInstallList.length;
   let projectsToActivate = [];
   let projectsToDownloadAndActivate = [];
 
   const handleClick = async () => {
     loading = true;
-    await processQueue();
+    await processInstallList();
     loading = false;
     $updated = new Date().getTime();
   };
@@ -29,7 +29,7 @@
   function clearSelection() {
     projectsToDownloadAndActivate = [];
     projectsToActivate = [];
-    clearQueue();
+    clearInstallList();
 
     $updated = new Date().getTime();
   }
@@ -48,17 +48,17 @@
 
 <div
   class=" views-bulk-actions pb-install_bulk_actions {bulkActionClasses}"
-  data-drupal-sticky-vbo={queueLength !== 0}
+  data-drupal-sticky-vbo={installListLength !== 0}
 >
   <div
     class="views-bulk-actions__item
   views-bulk-actions__item--status views-bulk-actions__item-gin"
   >
-    {#if queueLength === 0}
+    {#if installListLength === 0}
       {Drupal.t('No projects selected')}
     {:else}
       {Drupal.formatPlural(
-        queueLength,
+        installListLength,
         '1 project selected',
         '@count projects selected',
       )}
@@ -72,7 +72,7 @@
       <Loading />
       <LoadingEllipsis
         message={Drupal.formatPlural(
-          queueLength,
+          installListLength,
           'Installing 1 project',
           'Installing @count projects',
         )}
@@ -81,7 +81,7 @@
       {Drupal.t('Install selected projects')}
     {/if}
   </button>
-  {#if queueLength !== 0}
+  {#if installListLength !== 0}
     <button class="button clear_button" on:click={clearSelection}>
       {Drupal.t('Clear selection')}
     </button>

sveltejs/src/Project/ActionButton.svelte

@@ -6,12 +6,12 @@
   import ProjectIcon from './ProjectIcon.svelte';
   import LoadingEllipsis from './LoadingEllipsis.svelte';
   import {
-    processQueue,
-    addToQueue,
-    queueList,
-    removeFromQueue,
+    processInstallList,
+    addToInstallList,
+    installList,
+    removeFromInstallList,
     updated,
-  } from '../QueueProcessor';
+  } from '../InstallListProcessor';
 
   // eslint-disable-next-line import/no-mutable-exports,import/prefer-default-export
   export let project;
@@ -20,34 +20,34 @@
   const { Drupal } = window;
   const processMultipleProjects = MAX_SELECTIONS === null || MAX_SELECTIONS > 1;
 
-  $: isInQueue = $queueList.some((item) => item.id === project.id);
+  $: isInInstallList = $installList.some((item) => item.id === project.id);
 
-  // If MAX_SELECTIONS is null (no limit), then the queue is never full.
-  const queueFull = $queueList.length === MAX_SELECTIONS;
+  // If MAX_SELECTIONS is null (no limit), then the install list is never full.
+  const InstallListFull = $installList.length === MAX_SELECTIONS;
 
   let loading = false;
 
-  function handleAddToQueueClick(singleProject) {
-    addToQueue(singleProject);
+  function handleAddToInstallListClick(singleProject) {
+    addToInstallList(singleProject);
     $updated = new Date().getTime();
   }
 
-  function handleDequeueClick(projectId) {
-    removeFromQueue(projectId);
+  function handleRemoveFromInstallList(projectId) {
+    removeFromInstallList(projectId);
     $updated = new Date().getTime();
   }
 
   const onClick = async () => {
     if (processMultipleProjects) {
-      if (isInQueue) {
-        handleDequeueClick(project.id);
+      if (isInInstallList) {
+        handleRemoveFromInstallList(project.id);
       } else {
-        handleAddToQueueClick(project);
+        handleAddToInstallListClick(project);
       }
     } else {
-      handleAddToQueueClick(project);
+      handleAddToInstallListClick(project);
       loading = true;
-      await processQueue();
+      await processInstallList();
       loading = false;
       $updated = new Date().getTime();
     }
@@ -68,11 +68,11 @@
   {:else}
     <span>
       {#if PACKAGE_MANAGER.available && PACKAGE_MANAGER.errors.length === 0}
-        {#if isInQueue && !processMultipleProjects}
+        {#if isInInstallList && !processMultipleProjects}
           <ProjectButtonBase>
             <LoadingEllipsis />
           </ProjectButtonBase>
-        {:else if queueFull && !isInQueue && processMultipleProjects}
+        {:else if InstallListFull && !isInInstallList && processMultipleProjects}
           <ProjectButtonBase disabled>
             {@html Drupal.t(
               'Select <span class="visually-hidden">@title</span>',
@@ -83,7 +83,7 @@
           </ProjectButtonBase>
         {:else}
           <ProjectButtonBase click={onClick}>
-            {#if isInQueue}
+            {#if isInInstallList}
               {@html Drupal.t(
                 'Deselect <span class="visually-hidden">@title</span>',
                 {

sveltejs/src/ProjectBrowser.svelte

@@ -6,7 +6,7 @@
   import Pagination from './Pagination.svelte';
   import Project from './Project/Project.svelte';
   import { numberFormatter } from './util';
-  import { updated, queueList } from './QueueProcessor';
+  import { updated, installList } from './InstallListProcessor';
   import MediaQuery from './MediaQuery.svelte';
   import {
     BASE_URL,
@@ -145,7 +145,7 @@
    */
   onMount(async () => {
     if (MAX_SELECTIONS === 1) {
-      $queueList = [];
+      $installList = [];
     }
     const savedPageSize = localStorage.getItem('pageSize');
     if (savedPageSize) {

sveltejs/src/ProjectGrid.svelte

 <script context="module">
   import Search from './Search/Search.svelte';
   import Loading from './Loading.svelte';
-  import ProcessQueueButton from './ProcessQueueButton.svelte';
+  import ProcessInstallListButton from './ProcessInstallListButton.svelte';
 
   export { Search };
 </script>
@@ -73,7 +73,7 @@
         <slot rows={visibleRows} />
       </ul>
       {#if PACKAGE_MANAGER.available && processMultipleProjects}
-        <ProcessQueueButton />
+        <ProcessInstallListButton />
       {/if}
     {/if}
     <slot name="foot" />

tests/src/FunctionalJavascript/ProjectBrowserInstallerUiTest.php

@@ -417,9 +417,9 @@ class ProjectBrowserInstallerUiTest extends WebDriverTestBase {
   }
 
   /**
-   * Tests that adding projects to queue is plugin specific.
+   * Tests that adding projects to install list is plugin specific.
    */
-  public function testPluginSpecificQueue(): void {
+  public function testPluginSpecificInstallList(): void {
     $assert_session = $this->assertSession();
     $this->container->get('module_installer')->install(['project_browser_devel'], TRUE);
     $this->drupalGet('project-browser/project_browser_test_mock');