Skip to content
Snippets Groups Projects

Resolve #3425461 "Post rector report"

2 unresolved threads

Closes #3425461

Merge request reports

Merged results pipeline #127475 passed

Merged results pipeline passed for fad941cd

Test summary results are being parsed

Closed by Björn BralaBjörn Brala 1 year ago (Apr 3, 2024 1:00pm UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
515 $comment_tokens['info_yml_updated'] = $this->updatedInfoYml($file_path);
516 $info_is_updated = $this->updatedInfoYml($file_path);
517
518 // If the info file was not updated, there are error left that we know.
519 $post_rector_txt_path = FALSE;
520 if (!$info_is_updated) {
521 // Upload the previous file first (done here, as Save would also
522 // upload it and avoid one extra HTTP request this way).
523 $page->pressButton('Upload');
524
525 // Look for the post_rector report results.
526 $files = glob(static::RESULTS_DIR . '/*/*.post_rector.xml');
527 if (!empty($files)) {
528 $txt_contents = '';
529 $post_rector_xml = simplexml_load_file($files[0]);
530 foreach($xml->checkstyle->file as $file_result) {
  • Björn Brala
  • 512 513 // Set to needs review.
    513 514 $page->fillField('edit-field-issue-status-und', self::ISSUE_STATUS_NEEDS_REVIEW);
    514 515
    515 $comment_tokens['info_yml_updated'] = $this->updatedInfoYml($file_path);
    516 $info_is_updated = $this->updatedInfoYml($file_path);
    517
    518 // If the info file was not updated, there are error left that we know.
    519 $post_rector_txt_path = FALSE;
    520 if (!$info_is_updated) {
    521 // Upload the previous file first (done here, as Save would also
    522 // upload it and avoid one extra HTTP request this way).
    523 $page->pressButton('Upload');
    524
    525 // Look for the post_rector report results.
    526 $files = glob(static::RESULTS_DIR . '/*/*.post_rector.xml');
  • I;ve fixed a lot of things while merge, thanks for the help though :)

  • Björn Brala approved this merge request

    approved this merge request

  • closed

  • Please register or sign in to reply
    Loading