Draft: Issue #3197304: Provide form element and reuse that in field widget
Merge request reports
Activity
added 2 commits
added 2 commits
added 30 commits
-
726eb6ee - 1 commit from branch
project:8.x-2.x
- fb8fa61c - gen
- ec0fa3b6 - bits
- 5ecc6379 - should work?
- 3b29244c - fix
- 10434e59 - sort.
- 03997921 - works
- 21bdbaad - Added test module and test, WIP.
- 1627b254 - removed DI.
- 34adc1a0 - docs.
- 8419a512 - clean up test form.
- 1238d05d - plugin descs.
- 72252996 - clean up
- 6a847726 - set nested default values
- 0e6bc529 - added title to element
- dfbba7c5 - Allow plugin forms to set default values.
- 5104a2d7 - Added form element for just a plugin ID.
- 7e36358f - Added message when selected plugin has no configuration.
- c7a70e2e - Added hacky guard.
- 7333df2f - Pass the form element to the plugin’s form builder.
- 0c9e046b - fixup! Added message when selected plugin has no configuration.
- eab55a94 - Take title from original element.
- 19019609 - Formatting.
- 08ef94a1 - Add support for custom method.
- d9f9b48c - Added docs.
- f3ba5e53 - Added validation of plugin form and fixed plugin interface.
- e8816369 - removed class alias.
- f2330af2 - fixed sort order of imports
- 5accf3ba - Fixed subform.
- 5092d68b - Added docs.
Toggle commit list-
726eb6ee - 1 commit from branch
added 2 commits
added 39 commits
-
8948e7ee - 1 commit from branch
project:8.x-2.x
- 8948e7ee...ca0deef6 - 28 earlier commits
- af77cccf - Added docs.
- 3d0f2f73 - Allow forms to place elements inside the element.
- c844e89d - Pass the default value to the plugin form.
- 96518a6b - Get plugin default config; always show defaults.
- 8be2e639 - require both interfaces to show plugin form.
- ffaacd30 - Fixed missing closing brackets.
- 7cd87fd8 - broken non-JS support
- 9b5ecf4e - Fixed element description not shown.
- 7d5f74a0 - Fix code style.
- fe74e5b5 - WIP for non-JS support.
Toggle commit list-
8948e7ee - 1 commit from branch
added 2 commits
- src/Element/ConfiguredPlugin.php 0 → 100644
88 ]; 89 90 if ($selected_plugin_id = $form_state->getValue([...$element['#array_parents'], 'plugin_id'])) { 91 // A value set in the form by the user prior to an AJAX submission takes 92 // precedence. 93 } 94 elseif ($selected_plugin_id = $form_state->getValue([...$element['#array_parents'], 'container', 'plugin_id'])) { 95 // On a non-JS 'Choose' button submission, the valueCallback has not 96 // (yet?) run, and so our value is still inside the container. WTF. 97 } 98 elseif (isset($element['#default_value']['plugin_id'])) { 99 $selected_plugin_id = $element['#default_value']['plugin_id']; 100 } 101 else { 102 // If we still don't have anything, use an empty value. 103 $selected_entity_type_id = ''; @joachim Shouldn't this be
$selected_plugin_id
as well? It looks like this isn't used anywhere.changed this line in version 20 of the diff
Please register or sign in to reply